Issue 11474043: Wait for encode thread during VideoScheduler teardown.

Issue 11474043: Wait for encode thread during VideoScheduler teardown. (Closed)

Created:
8 years ago by Wez

Modified:
8 years ago

Reviewers:
alexeypa (please no reviews)

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Wait for encode thread during VideoScheduler teardown. VideoFrameCapturer currently owns the buffers underlying CaptureData instances, so VideoScheduler::Stop() mustn't notify completion until it is done accessing them. BUG=163641 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172280

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix call to StopOnEncodeThread #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -3 lines)			Patch
	M	remoting/host/video_scheduler.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	remoting/host/video_scheduler.cc	View	1	2 chunks	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

alexeypa (please no reviews)

lgtm with my comment addressed. https://chromiumcodereview.appspot.com/11474043/diff/1/remoting/host/video_scheduler.cc File remoting/host/video_scheduler.cc (right): https://chromiumcodereview.appspot.com/11474043/diff/1/remoting/host/video_scheduler.cc#newcode167 remoting/host/video_scheduler.cc:167: base::Bind(&VideoScheduler::StopOnCaptureThread, this, done_task)); VideoScheduler::StopOnCaptureThread ...

8 years ago (2012-12-10 21:10:11 UTC) #3

Wez

https://chromiumcodereview.appspot.com/11474043/diff/1/remoting/host/video_scheduler.cc File remoting/host/video_scheduler.cc (right): https://chromiumcodereview.appspot.com/11474043/diff/1/remoting/host/video_scheduler.cc#newcode167 remoting/host/video_scheduler.cc:167: base::Bind(&VideoScheduler::StopOnCaptureThread, this, done_task)); On 2012/12/10 21:10:12, alexeypa wrote: > ...

8 years ago (2012-12-10 22:33:50 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/11474043/6001

8 years ago (2012-12-11 03:40:36 UTC) #5

Message was sent while issue was closed.

Change committed as 172280

Expand Messages | Collapse Messages