Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: remoting/host/video_scheduler.cc

Issue 11474043: Wait for encode thread during VideoScheduler teardown. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix call to StopOnEncodeThread Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/video_scheduler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/video_scheduler.cc
diff --git a/remoting/host/video_scheduler.cc b/remoting/host/video_scheduler.cc
index cfc6827a91a6fb4f7acb43bc33455aad9356f466..c2a797e111f80f0070d61d44e0a66419ced4f3ad 100644
--- a/remoting/host/video_scheduler.cc
+++ b/remoting/host/video_scheduler.cc
@@ -176,9 +176,12 @@ void VideoScheduler::StopOnCaptureThread(const base::Closure& done_task) {
// |capture_timer_| must be destroyed on the thread on which it is used.
capture_timer_.reset();
- // Activity on the encode thread will stop implicitly as a result of
- // captures having stopped.
- network_task_runner_->PostTask(FROM_HERE, done_task);
+ // Ensure that the encode thread is no longer processing capture data,
+ // otherwise tearing down |capturer_| will crash it. See crbug.com/163641.
+ // TODO(wez): Make it safe to tear down capturer while buffers remain, and
+ // remove this work-around.
+ capture_task_runner_->PostTask(FROM_HERE,
+ base::Bind(&VideoScheduler::StopOnEncodeThread, this, done_task));
}
void VideoScheduler::ScheduleNextCapture() {
@@ -302,4 +305,12 @@ void VideoScheduler::EncodedDataAvailableCallback(
base::Passed(&packet)));
}
+void VideoScheduler::StopOnEncodeThread(const base::Closure& done_task) {
+ DCHECK(encode_task_runner_->BelongsToCurrentThread());
+
+ // This is posted by StopOnCaptureThread, so we know that by the time we
+ // process it there are no more encode tasks queued.
+ network_task_runner_->PostTask(FROM_HERE, done_task);
+}
+
} // namespace remoting
« no previous file with comments | « remoting/host/video_scheduler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698