Chromium Code Reviews
Help | Chromium Project | Sign in
(21)

Issue 11471046: Fetching Google Now Notifications data from the server (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by vadimt
Modified:
1 year, 4 months ago
CC:
chromium-reviews_chromium.org
Visibility:
Public.

Description

Fetching Google Now Notifications data from the server.

BUG=164227
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173005

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 10

Patch Set 3 : Travis and rgustafson's comments #

Total comments: 6

Patch Set 4 : sky@ comments #

Patch Set 5 : Fixing a leak found by compiler. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -37 lines) Lint Patch
M chrome/browser/ui/google_now/google_now_service.h View 1 2 3 5 chunks +12 lines, -8 lines 0 comments 1 errors Download
M chrome/browser/ui/google_now/google_now_service.cc View 1 2 3 4 5 chunks +75 lines, -29 lines 0 comments 1 errors Download
Commit:

Messages

Total messages: 12
vadimt
1 year, 4 months ago #1
rgustafson
lgtm Technically, things look fine to me, but I just want to point out that ...
1 year, 4 months ago #2
Travis Skare
lgtm likewise, technically looks ok. Here are a couple minor readability things and a couple ...
1 year, 4 months ago #3
vadimt
sky@, please provide owner's approval. Thanks! https://codereview.chromium.org/11471046/diff/2001/chrome/browser/ui/google_now/google_now_service.cc File chrome/browser/ui/google_now/google_now_service.cc (right): https://codereview.chromium.org/11471046/diff/2001/chrome/browser/ui/google_now/google_now_service.cc#newcode126 chrome/browser/ui/google_now/google_now_service.cc:126: switches::kEnableGoogleNowIntegration); On 2012/12/12 ...
1 year, 4 months ago #4
sky
https://codereview.chromium.org/11471046/diff/8001/chrome/browser/ui/google_now/google_now_service.cc File chrome/browser/ui/google_now/google_now_service.cc (right): https://codereview.chromium.org/11471046/diff/8001/chrome/browser/ui/google_now/google_now_service.cc#newcode127 chrome/browser/ui/google_now/google_now_service.cc:127: DCHECK(server_path.length() > 0); !empty https://codereview.chromium.org/11471046/diff/8001/chrome/browser/ui/google_now/google_now_service.h File chrome/browser/ui/google_now/google_now_service.h (right): https://codereview.chromium.org/11471046/diff/8001/chrome/browser/ui/google_now/google_now_service.h#newcode30 ...
1 year, 4 months ago #5
sky
1 year, 4 months ago #6
vadimt
https://codereview.chromium.org/11471046/diff/8001/chrome/browser/ui/google_now/google_now_service.cc File chrome/browser/ui/google_now/google_now_service.cc (right): https://codereview.chromium.org/11471046/diff/8001/chrome/browser/ui/google_now/google_now_service.cc#newcode127 chrome/browser/ui/google_now/google_now_service.cc:127: DCHECK(server_path.length() > 0); On 2012/12/13 00:38:46, sky wrote: > ...
1 year, 4 months ago #7
sky
LGTM
1 year, 4 months ago #8
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimt@chromium.org/11471046/14001
1 year, 4 months ago #9
I haz the power (commit-bot)
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
1 year, 4 months ago #10
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimt@chromium.org/11471046/28002
1 year, 4 months ago #11
I haz the power (commit-bot)
1 year, 4 months ago #12
Message was sent while issue was closed.
Change committed as 173005
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6