Log MediaSource parsing errors to the MediaLog so they can appear in chrome:media-internals.

Log MediaSource parsing errors to the MediaLog so they can appear in chrome:media-internals.


BUG=164673
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171936

[scherkus (not reviewing), 2012-12-07 20:40:10]

one q

https://codereview.chromium.org/11471006/diff/4003/media/base/media_log.h
File media/base/media_log.h (right):

https://codereview.chromium.org/11471006/diff/4003/media/base/media_log.h#new...
media/base/media_log.h:25: class ErrorLogHelper {
WDYT about dropping "Error" from everything?

not only do we save characters but it doesn't preclude using it for non-error
related messages

[acolwell GONE FROM CHROMIUM, 2012-12-07 21:19:20]

On 2012/12/07 20:40:10, scherkus wrote:
> one q
> 
> https://codereview.chromium.org/11471006/diff/4003/media/base/media_log.h
> File media/base/media_log.h (right):
> 
>
https://codereview.chromium.org/11471006/diff/4003/media/base/media_log.h#new...
> media/base/media_log.h:25: class ErrorLogHelper {
> WDYT about dropping "Error" from everything?
> 
> not only do we save characters but it doesn't preclude using it for non-error
> related messages

SGTM. I'll upload a new patch in a little bit.

[acolwell GONE FROM CHROMIUM, 2012-12-07 22:14:50]

PTAL

[scherkus (not reviewing), 2012-12-07 22:29:34]

lgtm w/ nit

https://codereview.chromium.org/11471006/diff/11002/media/base/media_log.h
File media/base/media_log.h (right):

https://codereview.chromium.org/11471006/diff/11002/media/base/media_log.h#ne...
media/base/media_log.h:20: // Indicates an error string should be added to the
error log.
s/error//g (or something that's less specific to errors)

[commit-bot: I haz the power, 2012-12-07 23:01:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/11471006/12002

[commit-bot: I haz the power, 2012-12-08 04:22:22]

Change committed as 171936