Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: media/filters/chunk_demuxer.h

Issue 11471006: Log MediaSource parsing errors to the MediaLog so they can appear in chrome:media-internals. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix nit. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/stream_parser.h ('k') | media/filters/chunk_demuxer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/chunk_demuxer.h
diff --git a/media/filters/chunk_demuxer.h b/media/filters/chunk_demuxer.h
index 6855b61170c7617aea6abed2ed8845a7de44c8d1..dde71aef489a7a391f0901ff48e71b3868b29f2d 100644
--- a/media/filters/chunk_demuxer.h
+++ b/media/filters/chunk_demuxer.h
@@ -40,7 +40,10 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
// is ready to receive media data via AppenData().
// |need_key_cb| Run when the demuxer determines that an encryption key is
// needed to decrypt the content.
- ChunkDemuxer(const base::Closure& open_cb, const NeedKeyCB& need_key_cb);
+ // |log_cb| Run when parsing error messages need to be logged to the error
+ // console.
+ ChunkDemuxer(const base::Closure& open_cb, const NeedKeyCB& need_key_cb,
+ const LogCB& log_cb);
// Demuxer implementation.
virtual void Initialize(DemuxerHost* host,
@@ -171,6 +174,7 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
DemuxerHost* host_;
base::Closure open_cb_;
NeedKeyCB need_key_cb_;
+ LogCB log_cb_;
PipelineStatusCB init_cb_;
PipelineStatusCB seek_cb_;
« no previous file with comments | « media/base/stream_parser.h ('k') | media/filters/chunk_demuxer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698