Migrate files to embedder.

Refactor generic android embedder code out of the sample and fix gcc warnings.

Committed: https://code.google.com/p/dart/source/detail?r=16869

[gram, 2013-01-09 17:51:36]

Looks good. I have convinced myself that it would be a great idea to have a
desktop OpenGL host too, so I think this will end up being refactored some more,
as we will want to share as much code between those as possible. This is a great
start though. Next step will be for me to move some of the additional work over
(mainly more sound support), and then I will look at the desktop host.

https://codereview.chromium.org/11467028/diff/4001/runtime/embedders/android/...
File runtime/embedders/android/eventloop.cc (left):

https://codereview.chromium.org/11467028/diff/4001/runtime/embedders/android/...
runtime/embedders/android/eventloop.cc:25: app_dummy();
Actually this line is very important and must be retained. It adds what would
otherwise br a missing dependency that would break NDK apps at run time. We
should add a comment to that effect.

https://codereview.chromium.org/11467028/diff/4001/runtime/embedders/android/...
File runtime/embedders/android/input_service.cc (left):

https://codereview.chromium.org/11467028/diff/4001/runtime/embedders/android/...
runtime/embedders/android/input_service.cc:107: 
Could we leave this in, and just comment out the last line? I think we are going
to need it in the future and would rather not have to dredge it up.

https://codereview.chromium.org/11467028/diff/4001/samples/android_sample/src...
File samples/android_sample/src/com/google/dartndk/DummyActivity.java (left):

https://codereview.chromium.org/11467028/diff/4001/samples/android_sample/src...
samples/android_sample/src/com/google/dartndk/DummyActivity.java:17:
System.loadLibrary("DartNDK");
I don't think we need to worry about this right now, but IIRC we should be able
to get rid of this static initializer; we needed it because we were loading more
than one native library. The dependency can instead be in one of the xml files.

[vsm, 2013-01-09 18:41:24]

PTAL

https://codereview.chromium.org/11467028/diff/4001/runtime/embedders/android/...
File runtime/embedders/android/eventloop.cc (left):

https://codereview.chromium.org/11467028/diff/4001/runtime/embedders/android/...
runtime/embedders/android/eventloop.cc:25: app_dummy();
On 2013/01/09 17:51:36, gram wrote:
> Actually this line is very important and must be retained. It adds what would
> otherwise br a missing dependency that would break NDK apps at run time. We
> should add a comment to that effect.

Added a comment to try to get this back in.

https://codereview.chromium.org/11467028/diff/4001/runtime/embedders/android/...
File runtime/embedders/android/input_service.cc (left):

https://codereview.chromium.org/11467028/diff/4001/runtime/embedders/android/...
runtime/embedders/android/input_service.cc:107: 
Done - added a TODO to use or remove.

On 2013/01/09 17:51:36, gram wrote:
> Could we leave this in, and just comment out the last line? I think we are
going
> to need it in the future and would rather not have to dredge it up.

https://codereview.chromium.org/11467028/diff/4001/samples/android_sample/src...
File samples/android_sample/src/com/google/dartndk/DummyActivity.java (left):

https://codereview.chromium.org/11467028/diff/4001/samples/android_sample/src...
samples/android_sample/src/com/google/dartndk/DummyActivity.java:17:
System.loadLibrary("DartNDK");
I actually tried to get rid of this and ran into a problem loading
android_embedder from the manifest.  I've added a TODO to try to figure this
out.

On 2013/01/09 17:51:36, gram wrote:
> I don't think we need to worry about this right now, but IIRC we should be
able
> to get rid of this static initializer; we needed it because we were loading
more
> than one native library. The dependency can instead be in one of the xml
files.

[gram, 2013-01-09 18:42:18]

lgtm