scripts/slave/slave_utils.py - Issue 11451004: Bugfixing URL construction for extract build step

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/slave_utils.py

Issue 11451004: Bugfixing URL construction for extract build step (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Removing urlparse + fix build_properties use Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/slave_utils.py

diff --git a/scripts/slave/slave_utils.py b/scripts/slave/slave_utils.py

index 0a6fcfb6386567adb6b12b2c293b1b4573eac026..6a627e13eb0c7678de94f52d2cb26fcc9d00cb27 100644

--- a/scripts/slave/slave_utils.py

+++ b/scripts/slave/slave_utils.py

@@ -93,7 +93,7 @@ def GetZipFileNames(build_properties, build_dir, webkit_dir=None,

base_name = 'full-build-%s' % chromium_utils.PlatformName()

chromium_revision = SubversionRevision(build_dir)

- if 'try' in build_properties.get('mastername'):

+ if 'try' in build_properties.get('mastername', ''):

kjellander_chromium 2012/12/28 16:47:31 Just to avoid an error if an empty build_propertie

if extract:

if not build_properties.get('parent_buildnumber'):

raise Exception('build_props does not have parent data: %s' %