Bugfixing URL construction for extract build step

scripts/slave/slave_utils.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Functions specific to build slaves, shared by several buildbot scripts.
 """
 
 import datetime
 import glob
 import os
@@ skipping 75 matching lines @@
       return 0
   except chromium_utils.ExternalError:
     return 0
 
 
 def GetZipFileNames(build_properties, build_dir, webkit_dir=None,
                     extract=False):
   base_name = 'full-build-%s' % chromium_utils.PlatformName()
 
   chromium_revision = SubversionRevision(build_dir)
-  if 'try' in build_properties.get('mastername'):
+  if 'try' in build_properties.get('mastername', ''):

[kjellander_chromium, 2012/12/28 16:47:31]

Just to avoid an error if an empty build_properties dict is passed.

     if extract:
       if not build_properties.get('parent_buildnumber'):
         raise Exception('build_props does not have parent data: %s' %
                         build_properties)
       version_suffix = '_%(parent_buildnumber)s' % build_properties
     else:
       version_suffix = '_%(buildnumber)s' % build_properties
   elif webkit_dir:
     webkit_revision = SubversionRevision(webkit_dir)
     version_suffix = '_wk%d_%d' % (webkit_revision, chromium_revision)
@@ skipping 502 matching lines @@
         'Platform "%s" is not currently supported.' % sys.platform)
 
 
 def WriteLogLines(logname, lines, perf=False):
   for line in lines:
     print '@@@STEP_LOG_LINE@%s@%s@@@' % (logname, line)
   if perf:
     print '@@@STEP_LOG_END_PERF@%s@@@' % logname
   else:
     print '@@@STEP_LOG_END@%s@@@' % logname