Issue 11447008: invocation_mirror_test passed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11447008: invocation_mirror_test passed (Closed)

Created:
8 years ago by Johnni Winther

Modified:
8 years ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

invocation_mirror_test passed BUG=http://dartbug.com/6907 Committed: https://code.google.com/p/dart/source/detail?r=15950

Patch Set 2 : co19 status updated #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -36 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View		7 chunks	+17 lines, -32 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/namer.dart	View		1 chunk	+15 lines, -0 lines	2 comments	Download
M	sdk/lib/_internal/compiler/implementation/universe/universe.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/11447008/diff/3001/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart File sdk/lib/_internal/compiler/implementation/js_backend/namer.dart (right): https://codereview.chromium.org/11447008/diff/3001/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart#newcode172 sdk/lib/_internal/compiler/implementation/js_backend/namer.dart:172: String nameString = selector.name.slowToString(); Remove this line.

8 years ago (2012-12-06 22:51:54 UTC) #2

Johnni Winther

8 years ago (2012-12-11 14:23:04 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/11447008/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/namer.dart (right):

https://codereview.chromium.org/11447008/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/namer.dart:172: String
nameString = selector.name.slowToString();
On 2012/12/06 22:51:54, ngeoffray wrote:
> Remove this line.

Removed in https://codereview.chromium.org/11415287/

Expand Messages | Collapse Messages

Issue 11447008: invocation_mirror_test passed (Closed)

Description

Patch Set 1 #

Patch Set 2 : co19 status updated #

Messages