Issue 11446035: include: fix String::New() comment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11446035: include: fix String::New() comment (Closed)

Created:
8 years ago by bnoordhuis1

Modified:
8 years ago

Reviewers:
v8-dev

Visibility:
Public.

More Reviews

Description

include: fix String::New() comment Committed: https://code.google.com/p/v8/source/detail?r=13231

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	include/v8.h	View		1 chunk	+2 lines, -6 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bnoordhuis1

https://codereview.chromium.org/11446035/diff/1/include/v8.h File include/v8.h (left): https://codereview.chromium.org/11446035/diff/1/include/v8.h#oldcode1261 include/v8.h:1261: * wrong if 'data' contains a null character. The ...

8 years ago (2012-12-06 03:59:54 UTC) #1

Yang

8 years ago (2012-12-18 09:19:53 UTC) #2

On 2012/12/06 03:59:54, bnoordhuis1 wrote:
> https://codereview.chromium.org/11446035/diff/1/include/v8.h
> File include/v8.h (left):
> 
> https://codereview.chromium.org/11446035/diff/1/include/v8.h#oldcode1261
> include/v8.h:1261: * wrong if 'data' contains a null character.
> The original author may have been thinking of UTF-16. UTF-8 is null character
> safe, \0 is never part of a multi-byte sequence.

LGTM. Landing.

Expand Messages | Collapse Messages