Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: include/v8.h

Issue 11446035: include: fix String::New() comment (Closed)
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index c422e172d2dd15dc51854faad7798bb216f2b623..8d3369ed40d2193981efa146b04ab45a5cdce5d2 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -1253,12 +1253,8 @@ class String : public Primitive {
/**
* Allocates a new string from either UTF-8 encoded or ASCII data.
- * The second parameter 'length' gives the buffer length.
- * If the data is UTF-8 encoded, the caller must
- * be careful to supply the length parameter.
- * If it is not given, the function calls
- * 'strlen' to determine the buffer length, it might be
- * wrong if 'data' contains a null character.
bnoordhuis1 2012/12/06 03:59:55 The original author may have been thinking of UTF-
+ * The second parameter 'length' gives the buffer length. If omitted,
+ * the function calls 'strlen' to determine the buffer length.
*/
V8EXPORT static Local<String> New(const char* data, int length = -1);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698