Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 11444020: DIAL extension API skeleton. (Closed)

Created:
8 years ago by justinlin
Modified:
8 years ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

DIAL (Discovery and Launch protocol) extension API skeleton. This implements the skeleton for a new Chrome extension API for local device discovery. The API will first be restricted to whitelisted extensions only. The API will allow extensions to receive events from a DIAL service running within Chrome which notifies of devices being discovered on the local network. Spec available here: https://docs.google.com/a/google.com/document/d/14FI-VKWrsMG7pIy3trgM3ybnKS-o5TULkt8itiBNXlQ/edit BUG=163288 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172243

Patch Set 1 #

Patch Set 2 : fix nits #

Total comments: 4

Patch Set 3 : Rebase, merge, fix tests #

Patch Set 4 : Use RunExtensionSubtests #

Patch Set 5 : abc.... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+903 lines, -2 lines) Patch
A chrome/browser/extensions/api/dial/dial_api.h View 1 2 1 chunk +98 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/dial/dial_api.cc View 1 2 1 chunk +125 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/dial/dial_api_factory.h View 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/dial/dial_api_factory.cc View 1 chunk +49 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/dial/dial_apitest.cc View 1 2 3 1 chunk +107 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/dial/dial_device_data.h View 1 chunk +81 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/dial/dial_device_data.cc View 1 chunk +74 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/dial/dial_registry.h View 1 chunk +70 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/dial/dial_registry.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M chrome/browser/extensions/event_names.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/event_names.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/api/dial.idl View 1 chunk +71 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/dial/experimental/discovery.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/dial/experimental/discovery.js View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/dial/experimental/manifest.json View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/dial/experimental/runtest.js View 1 2 3 1 chunk +50 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/dial/whitelist/manifest.json View 1 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/dial/whitelist/runtest.js View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
justinlin
Hi Aaron, PTAL. This is a skeleton for the new chrome extension API. Mark Foltz ...
8 years ago (2012-12-06 01:02:35 UTC) #1
justinlin
On 2012/12/06 01:02:35, justinlin wrote: > Hi Aaron, PTAL. This is a skeleton for the ...
8 years ago (2012-12-06 21:56:54 UTC) #2
Matt Perry
LGTM, some small nits. https://codereview.chromium.org/11444020/diff/4002/chrome/common/extensions/api/dial.idl File chrome/common/extensions/api/dial.idl (right): https://codereview.chromium.org/11444020/diff/4002/chrome/common/extensions/api/dial.idl#newcode68 chrome/common/extensions/api/dial.idl:68: static void onDeviceList(DialDevice[] result); onDeviceListChanged ...
8 years ago (2012-12-07 23:52:52 UTC) #3
justinlin
https://codereview.chromium.org/11444020/diff/4002/chrome/common/extensions/api/dial.idl File chrome/common/extensions/api/dial.idl (right): https://codereview.chromium.org/11444020/diff/4002/chrome/common/extensions/api/dial.idl#newcode68 chrome/common/extensions/api/dial.idl:68: static void onDeviceList(DialDevice[] result); On 2012/12/07 23:52:52, Matt Perry ...
8 years ago (2012-12-11 00:11:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/11444020/23039
8 years ago (2012-12-11 00:12:11 UTC) #5
commit-bot: I haz the power
Presubmit check for 11444020-23039 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-12-11 00:12:24 UTC) #6
sail
profiles/* LGMT!
8 years ago (2012-12-11 00:40:33 UTC) #7
sail
On 2012/12/11 00:40:33, sail wrote: > profiles/* LGMT! Argh, LGTM!
8 years ago (2012-12-11 00:40:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/11444020/23039
8 years ago (2012-12-11 00:44:27 UTC) #9
commit-bot: I haz the power
Presubmit check for 11444020-23039 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-12-11 00:44:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/11444020/24003
8 years ago (2012-12-11 00:52:58 UTC) #11
commit-bot: I haz the power
8 years ago (2012-12-11 02:59:46 UTC) #12
Message was sent while issue was closed.
Change committed as 172243

Powered by Google App Engine
This is Rietveld 408576698