Update gold linker to 2.23.1

Update gold linker to 2.23.1

This is the second attempt to integrate latest gold version.
The first time around there were crashes seen on 32-bit linux
hosts.  Disabling multi-threaded linking on 32-bit hosts
fixes the issue.


BUG=161942
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171917

[Sam Clegg, 2012-12-05 23:07:01]

+thestig

[Lei Zhang, 2012-12-05 23:17:56]

Can you just flip the flag for this condition near line 540 instead?

[Sam Clegg, 2012-12-05 23:26:01]

On 2012/12/05 23:17:56, Lei Zhang wrote:
> Can you just flip the flag for this condition near line 540 instead?

The linux_use_gold_flags controls more than just the --threads arg.  It also
appears to control the --icf arg, which I didn't want to mess with. 

Do we want a new flag for "gold_use_threads"?  I makes sense to me as this needs
to be disabled for chromeos and also will be needed for arm/linux builds too.

[Lei Zhang, 2012-12-05 23:33:56]

Ok, thanks for pointing that out. lgtm

[Lei Zhang, 2012-12-05 23:35:20]

On 2012/12/05 23:26:01, Sam Clegg wrote:
> Do we want a new flag for "gold_use_threads"?  I makes sense to me as this
needs
> to be disabled for chromeos and also will be needed for arm/linux builds too.

I'm really hoping this will be short lived and the gold bug will be fixed soon.
So let's not add more flags.

[commit-bot: I haz the power, 2012-12-06 04:16:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/11444012/2001

[commit-bot: I haz the power, 2012-12-06 05:38:39]

Retried try job too often on linux_chromeos for step(s) unit_tests

[commit-bot: I haz the power, 2012-12-06 07:52:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/11444012/2001

[commit-bot: I haz the power, 2012-12-06 13:55:21]

Retried try job too often on linux_chromeos for step(s) unit_tests

[commit-bot: I haz the power, 2012-12-06 16:26:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/11444012/2001

[commit-bot: I haz the power, 2012-12-06 19:40:22]

Retried try job too often on linux_chromeos for step(s) unit_tests

[commit-bot: I haz the power, 2012-12-06 20:51:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/11444012/2001

[Nico, 2012-12-06 21:39:27]

lgtm

[commit-bot: I haz the power, 2012-12-06 21:51:24]

Retried try job too often on linux_chromeos for step(s) unit_tests

[Sam Clegg, 2012-12-06 21:56:37]

On 2012/12/06 21:51:24, I haz the power (commit-bot) wrote:
> Retried try job too often on linux_chromeos for step(s) unit_tests

Any idea why this change can't get past the CQ?  I can't believe this
change effects the chromeos unit tests in any way can it?

[commit-bot: I haz the power, 2012-12-06 21:59:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/11444012/2001

[commit-bot: I haz the power, 2012-12-06 22:48:59]

Retried try job too often on linux_chromeos for step(s) unit_tests

[commit-bot: I haz the power, 2012-12-06 23:45:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/11444012/2001

[commit-bot: I haz the power, 2012-12-07 00:38:05]

Retried try job too often on linux_chromeos for step(s) unit_tests

[commit-bot: I haz the power, 2012-12-07 21:29:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/11444012/2001

[commit-bot: I haz the power, 2012-12-07 22:38:30]

Retried try job too often on linux_chromeos for step(s) unit_tests

[commit-bot: I haz the power, 2012-12-07 22:45:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/11444012/2001

[commit-bot: I haz the power, 2012-12-08 00:01:50]

Retried try job too often on linux_chromeos for step(s) unit_tests

[commit-bot: I haz the power, 2012-12-08 01:23:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/11444012/2001

[commit-bot: I haz the power, 2012-12-08 02:08:37]

Retried try job too often on linux_chromeos for step(s) unit_tests

[commit-bot: I haz the power, 2012-12-08 02:14:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/11444012/2001

[commit-bot: I haz the power, 2012-12-08 02:42:55]

Change committed as 171917