Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2352)

Unified Diff: build/common.gypi

Issue 11444012: Update gold linker to 2.23.1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 7388b7e458ac3c498f5af8061a1bc884da2c6ad5..0f694dde14a3180c371b2f3827d7d5c42195577d 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2787,14 +2787,19 @@
],
}],
['linux_use_gold_flags==1', {
- 'ldflags': [
- # Experimentation found that using four linking threads
- # saved ~20% of link time.
- # https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/281527606915bb36
- '-Wl,--threads',
- '-Wl,--thread-count=4',
- ],
'conditions': [
+ # Don't enable multi-threaded linking for 32-bit targets as it
+ # causes intermittent crashed on lucid32: http://crbug.com/161942
+ # TODO(sbc): remove this once gold bug is fixed
+ ['host_arch!="ia32"', {
+ 'ldflags': [
+ # Experimentation found that using four linking threads
+ # saved ~20% of link time.
+ # https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/281527606915bb36
+ '-Wl,--threads',
+ '-Wl,--thread-count=4',
+ ],
+ }],
['release_valgrind_build==0', {
'target_conditions': [
['_toolset=="target"', {
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698