Lazy initialization for ExtensionInputMethodEventRouter

Lazy initialization for ExtensionInputMethodEventRouter

Patch from Joe Thomas <mhx348@motorola.com>;.

BUG=159265
TBR=ben@chromium.org for gyp


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173642

[Joe Thomas, 2012-12-13 01:23:06]

+ben for gyp
+mirandac for profiles/

[Miranda Callahan, 2012-12-13 13:40:37]

On 2012/12/13 01:23:06, Joe Thomas wrote:
> +ben for gyp
> +mirandac for profiles/

profile_dependency_manager.cc LGTM

[Yoyo Zhou, 2012-12-13 18:27:03]

https://codereview.chromium.org/11442074/diff/1/chrome/browser/chromeos/exten...
File chrome/browser/chromeos/extensions/input_method_api.cc (right):

https://codereview.chromium.org/11442074/diff/1/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/input_method_api.cc:34:
router->GetInputMethodForXkb(manager->GetCurrentInputMethod().id());
I was looking at this earlier and it seems like GetInputMethodForXkb should be a
static function. (And it makes more sense for it to live in InputMethodAPI than
in InputMethodEventRouter, in my opinion.)

This means the input_method_event_router doesn't have to be started except in
OnListenerAdded.

[Ben Goodger (Google), 2012-12-13 21:43:28]

gyp lgtm

[Joe Thomas, 2012-12-17 20:56:27]

Thanks for the review.

https://codereview.chromium.org/11442074/diff/1/chrome/browser/chromeos/exten...
File chrome/browser/chromeos/extensions/input_method_api.cc (right):

https://codereview.chromium.org/11442074/diff/1/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/input_method_api.cc:34:
router->GetInputMethodForXkb(manager->GetCurrentInputMethod().id());
On 2012/12/13 18:27:03, Yoyo Zhou wrote:
> I was looking at this earlier and it seems like GetInputMethodForXkb should be
a
> static function. (And it makes more sense for it to live in InputMethodAPI
than
> in InputMethodEventRouter, in my opinion.)
> 
> This means the input_method_event_router doesn't have to be started except in
> OnListenerAdded.

Done. that makes sense.

[Joe Thomas, 2012-12-17 21:05:47]

@Yoyo:
Do we need to move this to any api specific folder?

Thanks
Joe

[Yoyo Zhou, 2012-12-17 21:43:18]

LGTM. No, we don't need to move it into any further folders;
chrome/browser/chromeos/extensions is an okay place for the ChromeOS-specific
extensions like this one for now.

[commit-bot: I haz the power, 2012-12-17 21:58:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/11442074/7001

[commit-bot: I haz the power, 2012-12-17 21:58:47]

Failed to apply patch for chrome/browser/extensions/extension_service.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/extension_service.h
  Hunk #1 succeeded at 52 (offset -2 lines).
  Hunk #2 FAILED at 559.
  Hunk #3 succeeded at 951 with fuzz 2 (offset -21 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/extensions/extension_service.h.rej

Patch:       chrome/browser/extensions/extension_service.h
Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h
b/chrome/browser/extensions/extension_service.h
index
9efbff78a5070f5646116a9616283ea30bab5155..2904e3cfdfb7590f08d0a5a5a69f137c0974424f
100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -54,10 +54,6 @@ namespace base {
 class SequencedTaskRunner;
 }
 
-namespace chromeos {
-class ExtensionInputMethodEventRouter;
-}
-
 namespace extensions {
 class AppNotificationManager;
 class AppSyncData;
@@ -563,12 +559,6 @@ class ExtensionService
     return browser_event_router_.get();
   }
 
-#if defined(OS_CHROMEOS)
-  chromeos::ExtensionInputMethodEventRouter* input_method_event_router() {
-    return input_method_event_router_.get();
-  }
-#endif
-
   extensions::PushMessagingEventRouter* push_messaging_event_router() {
     return push_messaging_event_router_.get();
   }
@@ -976,11 +966,6 @@ class ExtensionService
   scoped_ptr<extensions::PushMessagingEventRouter>
       push_messaging_event_router_;
 
-#if defined(OS_CHROMEOS)
-  scoped_ptr<chromeos::ExtensionInputMethodEventRouter>
-      input_method_event_router_;
-#endif
-
   // A collection of external extension providers.  Each provider reads
   // a source of external extension information.  Examples include the
   // windows registry and external_extensions.json.

[Joe Thomas, 2012-12-17 22:40:02]

On 2012/12/17 21:43:18, Yoyo Zhou wrote:
> LGTM. No, we don't need to move it into any further folders;
> chrome/browser/chromeos/extensions is an okay place for the ChromeOS-specific
> extensions like this one for now.

Ok. Thanks.

[commit-bot: I haz the power, 2012-12-17 22:55:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/11442074/16001

[commit-bot: I haz the power, 2012-12-18 01:00:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/11442074/16001

[commit-bot: I haz the power, 2012-12-18 01:51:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/11442074/16001

[commit-bot: I haz the power, 2012-12-18 04:25:45]

Change committed as 173642