rlz/lib/string_utils.cc - Issue 11434029: Fix tautological compare in rlz.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: rlz/lib/string_utils.cc

Issue 11434029: Fix tautological compare in rlz. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: rlz/lib/string_utils.cc

diff --git a/rlz/lib/string_utils.cc b/rlz/lib/string_utils.cc

index 50206a8e550916652bb1da34991814c56c7aa63f..87988022e41ad4ed1e7fd2e25a443ee0c15c613f 100644

--- a/rlz/lib/string_utils.cc

+++ b/rlz/lib/string_utils.cc

@@ -10,8 +10,8 @@

namespace rlz_lib {

-bool IsAscii(char letter) {

- return (letter >= 0x0 && letter < 0x80);

+bool IsAscii(unsigned char letter) {

+ return letter < 0x80;

}

bool GetHexValue(char letter, int* value) {

« no previous file with comments | « rlz/lib/string_utils.h ('k') | no next file » | no next file with comments »