Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Side by Side Diff: rlz/lib/string_utils.cc

Issue 11434029: Fix tautological compare in rlz. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « rlz/lib/string_utils.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // String manipulation functions used in the RLZ library. 5 // String manipulation functions used in the RLZ library.
6 6
7 #include "rlz/lib/string_utils.h" 7 #include "rlz/lib/string_utils.h"
8 8
9 #include "rlz/lib/assert.h" 9 #include "rlz/lib/assert.h"
10 10
11 namespace rlz_lib { 11 namespace rlz_lib {
12 12
13 bool IsAscii(char letter) { 13 bool IsAscii(unsigned char letter) {
14 return (letter >= 0x0 && letter < 0x80); 14 return letter < 0x80;
15 } 15 }
16 16
17 bool GetHexValue(char letter, int* value) { 17 bool GetHexValue(char letter, int* value) {
18 if (!value) { 18 if (!value) {
19 ASSERT_STRING("GetHexValue: Invalid output paramter"); 19 ASSERT_STRING("GetHexValue: Invalid output paramter");
20 return false; 20 return false;
21 } 21 }
22 *value = 0; 22 *value = 0;
23 23
24 if (letter >= '0' && letter <= '9') 24 if (letter >= '0' && letter <= '9')
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 int index = data_len; 83 int index = data_len;
84 while (index--) { 84 while (index--) {
85 string->at(2 * index) = kHex[data[index] >> 4]; // high digit 85 string->at(2 * index) = kHex[data[index] >> 4]; // high digit
86 string->at(2 * index + 1) = kHex[data[index] & 0x0F]; // low digit 86 string->at(2 * index + 1) = kHex[data[index] & 0x0F]; // low digit
87 } 87 }
88 88
89 return true; 89 return true;
90 } 90 }
91 91
92 } // namespace rlz_lib 92 } // namespace rlz_lib
OLDNEW
« no previous file with comments | « rlz/lib/string_utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698