Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 11434029: Fix tautological compare in rlz. (Closed)

Created:
8 years ago by hans
Modified:
8 years ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Fix tautological compare in rlz. This fixes this warning from a recent version of Clang: rlz/lib/string_utils.cc:14:35: error: comparison of constant 128 with expression of type 'char' is always true [-Werror,-Wtautological-constant-out-of-range-compare] return (letter >= 0x0 && letter < 0x80); ~~~~~~ ^ ~~~~ BUG=163104 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170265

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M rlz/lib/string_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M rlz/lib/string_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hans
8 years ago (2012-11-29 13:34:10 UTC) #1
Nico
lgtm
8 years ago (2012-11-29 20:30:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/11434029/1
8 years ago (2012-11-29 20:31:01 UTC) #3
commit-bot: I haz the power
8 years ago (2012-11-29 22:51:51 UTC) #4
Message was sent while issue was closed.
Change committed as 170265

Powered by Google App Engine
This is Rietveld 408576698