Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 11434008: Merge 135720 - Web Inspector: object preview does not render node id, className; logs too many func… (Closed)

Created:
8 years ago by pfeldman
Modified:
8 years ago
Reviewers:
pfeldman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 135720 - Web Inspector: object preview does not render node id, className; logs too many functions for jQuery. https://bugs.webkit.org/show_bug.cgi?id=103222 Reviewed by Yury Semikhatsky. Source/WebCore: - Added node class name and id into the preview - Now keeps track of properties separately from array indexes. * inspector/InjectedScriptSource.js: (.): * inspector/InspectorOverlayPage.html: * inspector/front-end/ConsoleMessage.js: (WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview): (WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreview): LayoutTests: * inspector/console/command-line-api-expected.txt: * inspector/console/command-line-api-inspect-expected.txt: * inspector/console/console-dir-expected.txt: * inspector/console/console-format-collections-expected.txt: * inspector/console/console-format-expected.txt: * inspector/elements/event-listener-sidebar-expected.txt: * inspector/elements/event-listeners-about-blank-expected.txt: * platform/chromium-linux/inspector/console/console-format-collections-expected.txt: Removed. * platform/chromium/inspector/console/command-line-api-inspect-expected.txt: * platform/chromium/inspector/console/console-dir-expected.txt: * platform/chromium/inspector/console/console-format-collections-expected.txt: TBR=pfeldman@chromium.org BUG=135720 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -52 lines) Patch
M LayoutTests/inspector/console/command-line-api-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/command-line-api-inspect-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-dir-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-format-collections-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/inspector/console/console-format-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/event-listener-sidebar-expected.txt View 7 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/inspector/elements/event-listeners-about-blank-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/chromium/inspector/console/command-line-api-inspect-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium/inspector/console/console-dir-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium/inspector/console/console-format-collections-expected.txt View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/WebCore/inspector/InjectedScriptSource.js View 5 chunks +27 lines, -9 lines 0 comments Download
M Source/WebCore/inspector/InspectorOverlayPage.html View 2 chunks +12 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/front-end/ConsoleMessage.js View 2 chunks +34 lines, -11 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
pfeldman
8 years ago (2012-11-28 20:29:14 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698