Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: Source/WebCore/inspector/InspectorOverlayPage.html

Issue 11434008: Merge 135720 - Web Inspector: object preview does not render node id, className; logs too many func… (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <!-- 1 <!--
2 Copyright (C) 2012 Google Inc. All rights reserved. 2 Copyright (C) 2012 Google Inc. All rights reserved.
3 3
4 Redistribution and use in source and binary forms, with or without 4 Redistribution and use in source and binary forms, with or without
5 modification, are permitted provided that the following conditions 5 modification, are permitted provided that the following conditions
6 are met: 6 are met:
7 7
8 1. Redistributions of source code must retain the above copyright 8 1. Redistributions of source code must retain the above copyright
9 notice, this list of conditions and the following disclaimer. 9 notice, this list of conditions and the following disclaimer.
10 2. Redistributions in binary form must reproduce the above copyright 10 2. Redistributions in binary form must reproduce the above copyright
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 .px { 76 .px {
77 color: rgb(128, 128, 128); 77 color: rgb(128, 128, 128);
78 } 78 }
79 79
80 #element-title { 80 #element-title {
81 position: absolute; 81 position: absolute;
82 z-index: 10; 82 z-index: 10;
83 } 83 }
84 84
85 #tag-name { 85 #tag-name {
86 /* Keep this in sync with view-source.css (.webkit-html-tag-name) */
86 color: rgb(136, 18, 128); 87 color: rgb(136, 18, 128);
87 } 88 }
88 89
89 #node-id { 90 #node-id {
91 /* Keep this in sync with view-source.css (.webkit-html-attribute-value) */
90 color: rgb(26, 26, 166); 92 color: rgb(26, 26, 166);
91 } 93 }
92 94
95 #class-name {
96 /* Keep this in sync with view-source.css (.webkit-html-attribute-name) */
97 color: rgb(153, 69, 0);
98 }
99
93 #right-gutter { 100 #right-gutter {
94 display: none; 101 display: none;
95 right: 0; 102 right: 0;
96 top: 0; 103 top: 0;
97 bottom: 0; 104 bottom: 0;
98 position: absolute; 105 position: absolute;
99 background-color: darkgray; 106 background-color: darkgray;
100 } 107 }
101 108
102 #bottom-gutter { 109 #bottom-gutter {
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 document.body.classList.remove("dimmed"); 335 document.body.classList.remove("dimmed");
329 } 336 }
330 337
331 function _drawElementTitle(highlight) 338 function _drawElementTitle(highlight)
332 { 339 {
333 var elementInfo = highlight.elementInfo; 340 var elementInfo = highlight.elementInfo;
334 if (!highlight.elementInfo) 341 if (!highlight.elementInfo)
335 return; 342 return;
336 343
337 document.getElementById("tag-name").textContent = elementInfo.tagName; 344 document.getElementById("tag-name").textContent = elementInfo.tagName;
338 document.getElementById("node-id").textContent = elementInfo.nodeId ? "#" + elementInfo.nodeId : ""; 345 document.getElementById("node-id").textContent = elementInfo.idValue ? "#" + elementInfo.idValue : "";
339 document.getElementById("class-name").textContent = elementInfo.className || ""; 346 var className = elementInfo.className;
347 if (className.length > 50)
348 className = className.substring(0, 50) + "\u2026";
349 document.getElementById("class-name").textContent = className;
340 document.getElementById("node-width").textContent = elementInfo.nodeWidth; 350 document.getElementById("node-width").textContent = elementInfo.nodeWidth;
341 document.getElementById("node-height").textContent = elementInfo.nodeHeight; 351 document.getElementById("node-height").textContent = elementInfo.nodeHeight;
342 var elementTitle = document.getElementById("element-title"); 352 var elementTitle = document.getElementById("element-title");
343 353
344 var marginQuad = highlight.quads[0]; 354 var marginQuad = highlight.quads[0];
345 355
346 var titleWidth = elementTitle.offsetWidth + 6; 356 var titleWidth = elementTitle.offsetWidth + 6;
347 var titleHeight = elementTitle.offsetHeight + 4; 357 var titleHeight = elementTitle.offsetHeight + 4;
348 358
349 var anchorTop = marginQuad[0].y; 359 var anchorTop = marginQuad[0].y;
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
563 </body> 573 </body>
564 <canvas id="canvas" class="fill"></canvas> 574 <canvas id="canvas" class="fill"></canvas>
565 <div id="element-title"> 575 <div id="element-title">
566 <span id="tag-name"></span><span id="node-id"></span><span id="class-name"></s pan> 576 <span id="tag-name"></span><span id="node-id"></span><span id="class-name"></s pan>
567 <span id="node-width"></span><span class="px">px</span><span class="px"> &#xD7 ; </span><span id="node-height"></span><span class="px">px</span> 577 <span id="node-width"></span><span class="px">px</span><span class="px"> &#xD7 ; </span><span id="node-height"></span><span class="px">px</span>
568 </div> 578 </div>
569 <div id="right-gutter"></div> 579 <div id="right-gutter"></div>
570 <div id="bottom-gutter"></div> 580 <div id="bottom-gutter"></div>
571 <div id="log"></div> 581 <div id="log"></div>
572 </html> 582 </html>
OLDNEW
« no previous file with comments | « Source/WebCore/inspector/InjectedScriptSource.js ('k') | Source/WebCore/inspector/front-end/ConsoleMessage.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698