Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 11428066: Use WS_POPUP for ash_unittests (Closed)

Created:
8 years ago by oshima
Modified:
8 years ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Use WS_POPUP for ash_unittests - Layout test windows starting from (1,1) and move mouse to (0,0) so that they don't overlap unless test moves the cursor. - Enabled disabled tests. - RootWindowHostWin::SetBounds should move the window and call OnHostResized when the scale factor has changed. This also seems to fix the desktop size limitation issue (148691) probably because a popup window can be larger than the desktop size. BUG=150986, 157817, 141577, 148691 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170621 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170673

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -167 lines) Patch
M ash/dip_unittest.cc View 1 1 chunk +1 line, -8 lines 0 comments Download
M ash/display/display_controller_unittest.cc View 1 2 7 chunks +13 lines, -29 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 1 10 chunks +13 lines, -51 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 1 3 chunks +2 lines, -19 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download
M ash/screen_ash_unittest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 2 3 3 chunks +13 lines, -1 line 0 comments Download
M ash/test/display_manager_test_api.cc View 1 2 2 chunks +13 lines, -9 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 9 chunks +6 lines, -35 lines 0 comments Download
M ui/aura/root_window.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M ui/aura/root_window_host_win.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M ui/aura/root_window_host_win.cc View 1 2 4 chunks +28 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
oshima
8 years ago (2012-11-30 21:06:37 UTC) #1
Ben Goodger (Google)
lgtm
8 years ago (2012-11-30 21:12:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/11428066/7004
8 years ago (2012-11-30 21:28:52 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) aura_unittests, content_browsertests, content_unittests, views_unittests
8 years ago (2012-11-30 21:47:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/11428066/7004
8 years ago (2012-11-30 21:58:21 UTC) #5
commit-bot: I haz the power
Change committed as 170621
8 years ago (2012-12-01 01:48:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/11428066/14017
8 years ago (2012-12-01 08:12:24 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-01 12:10:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/11428066/14017
8 years ago (2012-12-01 15:54:12 UTC) #9
commit-bot: I haz the power
8 years ago (2012-12-01 19:45:00 UTC) #10
Message was sent while issue was closed.
Change committed as 170673

Powered by Google App Engine
This is Rietveld 408576698