Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: ash/root_window_controller_unittest.cc

Issue 11428066: Use WS_POPUP for ash_unittests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/extended_desktop_unittest.cc ('k') | ash/screen_ash_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/root_window_controller_unittest.cc
diff --git a/ash/root_window_controller_unittest.cc b/ash/root_window_controller_unittest.cc
index a1f3c3ec56ed7f2ec8a5f3ef9d31b84017c55c8e..e8f57639ddbf346dbabcf8ce638463161e5a0a9e 100644
--- a/ash/root_window_controller_unittest.cc
+++ b/ash/root_window_controller_unittest.cc
@@ -119,12 +119,10 @@ TEST_F(RootWindowControllerTest, MoveWindows_Basic) {
views::Widget* maximized = CreateTestWidget(gfx::Rect(700, 10, 100, 100));
maximized->Maximize();
EXPECT_EQ(root_windows[1], maximized->GetNativeView()->GetRootWindow());
-#if !defined(OS_WIN)
- // TODO(oshima): Window reports smaller screen size. Investigate why.
+
EXPECT_EQ("600,0 500x500", maximized->GetWindowBoundsInScreen().ToString());
EXPECT_EQ("0,0 500x500",
maximized->GetNativeView()->GetBoundsInRootWindow().ToString());
-#endif
views::Widget* minimized = CreateTestWidget(gfx::Rect(800, 10, 100, 100));
minimized->Minimize();
@@ -135,13 +133,11 @@ TEST_F(RootWindowControllerTest, MoveWindows_Basic) {
views::Widget* fullscreen = CreateTestWidget(gfx::Rect(900, 10, 100, 100));
fullscreen->SetFullscreen(true);
EXPECT_EQ(root_windows[1], fullscreen->GetNativeView()->GetRootWindow());
-#if !defined(OS_WIN)
- // TODO(oshima): Window reports smaller screen size. Investigate why.
+
EXPECT_EQ("600,0 500x500",
fullscreen->GetWindowBoundsInScreen().ToString());
EXPECT_EQ("0,0 500x500",
fullscreen->GetNativeView()->GetBoundsInRootWindow().ToString());
-#endif
// Make sure a window that will delete itself when losing focus
// will not crash.
« no previous file with comments | « ash/extended_desktop_unittest.cc ('k') | ash/screen_ash_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698