Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11428058: Don't return false if PRINTER_INFO_9 is not available. (Closed)

Created:
8 years ago by Vitaly Buka (NO REVIEWS)
Modified:
8 years ago
Reviewers:
gene
CC:
chromium-reviews
Visibility:
Public.

Description

Speculative fix of attached bug. Don't return false if PRINTER_INFO_9 is not available. More logging in GetPrinterSemanticCapsAndDefaults. BUG=161772 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170396

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M chrome/browser/printing/print_system_task_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/print_backend_win.cc View 3 chunks +20 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Vitaly Buka (NO REVIEWS)
Please review
8 years ago (2012-11-28 23:31:19 UTC) #1
gene
lgtm
8 years ago (2012-11-28 23:39:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/11428058/3001
8 years ago (2012-11-28 23:50:31 UTC) #3
commit-bot: I haz the power
Failed to trigger a try job on android_dbg HTTP Error 400: Bad Request
8 years ago (2012-11-29 20:44:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/11428058/4004
8 years ago (2012-11-29 20:45:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/11428058/4004
8 years ago (2012-11-30 00:45:26 UTC) #6
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
8 years ago (2012-11-30 02:46:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/11428058/4004
8 years ago (2012-11-30 03:07:26 UTC) #8
commit-bot: I haz the power
8 years ago (2012-11-30 04:06:11 UTC) #9
Message was sent while issue was closed. 
Change committed as 170396

Powered by Google App Engine
This is Rietveld 408576698