Don't return false if PRINTER_INFO_9 is not available.

printing/backend/print_backend_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/backend/print_backend.h"
 
 #include <objidl.h>
 #include <winspool.h>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/string_piece.h"
 #include "base/utf_string_conversions.h"
 #include "base/win/scoped_bstr.h"
 #include "base/win/scoped_comptr.h"
 #include "base/win/scoped_hglobal.h"
 #include "printing/backend/print_backend_consts.h"
 #include "printing/backend/win_helper.h"
 
 namespace {
 
 // This class is designed to work with PRINTER_INFO_X structures
 // and calls GetPrinter internally with correctly allocated buffer.
 template <typename T>
 class PrinterInfo {
  public:
   bool GetPrinterInfo(HANDLE printer, int level) {
     DWORD buf_size = 0;
     GetPrinter(printer, level, NULL, 0, &buf_size);
-    if (buf_size == 0)
+    if (buf_size == 0) {
+      LOG(WARNING) << "Failed to GetPrinter, error = " << GetLastError();
       return false;
+    }
     buffer_.reset(new uint8[buf_size]);
     memset(buffer_.get(), 0, buf_size);
     return !!GetPrinter(printer, level, buffer_.get(), buf_size, &buf_size);
   }
 
   const T* get() const {
     return reinterpret_cast<T*>(buffer_.get());
   }
 
  private:
@@ skipping 78 matching lines @@
   return WideToUTF8(default_printer_name);
 }
 
 bool PrintBackendWin::GetPrinterSemanticCapsAndDefaults(
     const std::string& printer_name,
     PrinterSemanticCapsAndDefaults* printer_info) {
   ScopedPrinterHandle printer_handle;
   OpenPrinter(const_cast<LPTSTR>(UTF8ToWide(printer_name).c_str()),
               printer_handle.Receive(), NULL);
   DCHECK(printer_handle);
-  if (!printer_handle.IsValid())
+  if (!printer_handle.IsValid()) {
+    LOG(WARNING) << "Failed to open printer, error = " << GetLastError();
     return false;
+  }
 
   PrinterInfo<PRINTER_INFO_5> info_5;
-  if (!info_5.GetPrinterInfo(printer_handle, 5))
+  if (!info_5.GetPrinterInfo(printer_handle, 5)) {
+    LOG(WARNING) << "Failed to get PRINTER_INFO_5, error = " << GetLastError();
     return false;
+  }
 
   // Get printer capabilities. For more info see here:
   // http://msdn.microsoft.com/en-us/library/windows/desktop/dd183552(v=vs.85).aspx
   bool color_supported = (DeviceCapabilities(info_5.get()->pPrinterName,
                                              info_5.get()->pPortName,
                                              DC_COLORDEVICE,
                                              NULL,
                                              NULL) == 1);
 
   bool duplex_supported = (DeviceCapabilities(info_5.get()->pPrinterName,
                                               info_5.get()->pPortName,
                                               DC_DUPLEX,
                                               NULL,
                                               NULL) == 1);
 
+  DEVMODE* devmode = NULL;
   // PRINTER_INFO_9 retrieves current user settings.
   PrinterInfo<PRINTER_INFO_9> info_9;
-  if (!info_9.GetPrinterInfo(printer_handle, 9))
-    return false;
-  DEVMODE* devmode = info_9.get()->pDevMode;
+  if (info_9.GetPrinterInfo(printer_handle, 9)) {
+    devmode = info_9.get()->pDevMode;
+  } else {
+    LOG(WARNING) << "Failed to get PRINTER_INFO_9, error = " << GetLastError();
+  }
 
   // Sometimes user settings are not available (have not been setted up yet).
   // Use printer default settings (PRINTER_INFO_8) in this case.
   PrinterInfo<PRINTER_INFO_8> info_8;
   if (!devmode) {
-    if (info_8.GetPrinterInfo(printer_handle, 8))
+    if (info_8.GetPrinterInfo(printer_handle, 8)) {
       devmode = info_8.get()->pDevMode;
+    } else {
+      LOG(WARNING) << "Failed to get PRINTER_INFO_8, error = " <<
+                      GetLastError();
+    }
   }
   if (!devmode)
     return false;
 
   PrinterSemanticCapsAndDefaults caps;
   caps.color_capable = color_supported;
   if ((devmode->dmFields & DM_COLOR) == DM_COLOR)
     caps.color_default = (devmode->dmColor == DMCOLOR_COLOR);
 
   caps.duplex_capable = duplex_supported;
@@ skipping 109 matching lines @@
               printer_handle.Receive(), NULL);
   return printer_handle.IsValid();
 }
 
 scoped_refptr<PrintBackend> PrintBackend::CreateInstance(
     const base::DictionaryValue* print_backend_settings) {
   return new PrintBackendWin;
 }
 
 }  // namespace printing