Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3033)

Unified Diff: build/android/pylib/base_test_sharder.py

Issue 11421149: Ensure host_forwarder is killed when setting up/tearing down sharding. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Marcus' comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/pylib/forwarder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/base_test_sharder.py
diff --git a/build/android/pylib/base_test_sharder.py b/build/android/pylib/base_test_sharder.py
index fa05abec4e202b77d422fd2a29bcd5f20dfe996d..1c4559ad4582ddb2d757dd3fc5e5fa4bd27dcdd3 100644
--- a/build/android/pylib/base_test_sharder.py
+++ b/build/android/pylib/base_test_sharder.py
@@ -66,10 +66,13 @@ class BaseTestSharder(object):
def SetupSharding(self, tests):
"""Called before starting the shards."""
- Forwarder.KillHost(self.build_type)
+ pass
def OnTestsCompleted(self, test_runners, test_results):
"""Notifies that we completed the tests."""
+ pass
+
+ def _KillHostForwarder(self):
Forwarder.KillHost(self.build_type)
def RunShardedTests(self):
@@ -85,6 +88,7 @@ class BaseTestSharder(object):
logging.warning('Look for the "Final result" banner in the end.')
logging.warning('*' * 80)
final_results = TestResults()
+ self._KillHostForwarder()
for retry in xrange(self.retries):
logging.warning('Try %d of %d', retry + 1, self.retries)
self.SetupSharding(self.tests)
@@ -142,4 +146,5 @@ class BaseTestSharder(object):
# There's no recovery at this point.
raise Exception('Unrecoverable error while retrying test runs.')
self.OnTestsCompleted(test_runners, final_results)
+ self._KillHostForwarder()
return final_results
« no previous file with comments | « no previous file | build/android/pylib/forwarder.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698