Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: build/android/pylib/forwarder.py

Issue 11421149: Ensure host_forwarder is killed when setting up/tearing down sharding. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Marcus' comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/base_test_sharder.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/forwarder.py
diff --git a/build/android/pylib/forwarder.py b/build/android/pylib/forwarder.py
index 305278f9a3a42b94b10d582cfba128ad57a11aa5..460a3dc97ac0fce75559fb73e13b77a1670b076e 100644
--- a/build/android/pylib/forwarder.py
+++ b/build/android/pylib/forwarder.py
@@ -105,12 +105,16 @@ class Forwarder(object):
@staticmethod
def KillHost(build_type):
+ logging.info('Killing host_forwarder.')
host_forwarder_path = _MakeBinaryPath(build_type, 'host_forwarder')
(exit_code, output) = cmd_helper.GetCmdStatusAndOutput(
[host_forwarder_path, 'kill-server'])
if exit_code != 0:
- raise Exception('%s exited with %d:\n%s' % (host_forwarder_path,
- exit_code, '\n'.join(output)))
+ (exit_code, output) = cmd_helper.GetCmdStatusAndOutput(
+ ['pkill', 'host_forwarder'])
+ if exit_code != 0:
+ raise Exception('%s exited with %d:\n%s' % (
+ host_forwarder_path, exit_code, '\n'.join(output)))
@staticmethod
def KillDevice(adb):
« no previous file with comments | « build/android/pylib/base_test_sharder.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698