Add public accounts to UserManager

chrome/browser/chromeos/settings/cros_settings.h

Index: chrome/browser/chromeos/settings/cros_settings.h
diff --git a/chrome/browser/chromeos/settings/cros_settings.h b/chrome/browser/chromeos/settings/cros_settings.h
index 4148ee69e848f90af14a60e2851a5ac7cfdb68a0..9accdfebe74e7f630922571fd950c59ff896a2aa 100644
--- a/chrome/browser/chromeos/settings/cros_settings.h
+++ b/chrome/browser/chromeos/settings/cros_settings.h
@@ -107,7 +107,7 @@ class CrosSettings : public base::NonThreadSafe {
 
   // A map from settings names to a list of observers. Observers get fired in
   // the order they are added.
-  typedef ObserverList<content::NotificationObserver, true>
+  typedef ObserverList<content::NotificationObserver, false>

[pastarmovj, 2012/11/28 09:57:16]

Why did you do that? Is this observer not removed properly?

[bartfab (slow), 2012/11/28 12:30:17]

As discussed offline: I need UserManager to be a CrosSettings observer. Since
UserManager and CrosSettings are both singletons (with undefined shutdown
order), I had to handle both shutdown orders:

* If CrosSettings goes down first, it must accept the fact that UserManager is
still registered as an observer (thus the |false| here).
* If UserManager goes down first, it must unregister itself as an observer
(problem: it does not know whether CrosSettings is still alive) or invalidate
the observer in some other way (I used WeakPtr for this).

These points are now moot as I added a UserManager::Shutdown() method that gets
called during shutdown and allows the UserManager to unregister cleanly.

       NotificationObserverList;
   typedef base::hash_map<std::string, NotificationObserverList*>
       SettingsObserverMap;