Add public accounts to UserManager

chrome/browser/chromeos/settings/cros_settings.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_SETTINGS_CROS_SETTINGS_H_
 #define CHROME_BROWSER_CHROMEOS_SETTINGS_CROS_SETTINGS_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 89 matching lines @@
   ~CrosSettings();
 
   // Fires system setting change notification.
   void FireObservers(const std::string& path);
 
   // List of ChromeOS system settings providers.
   std::vector<CrosSettingsProvider*> providers_;
 
   // A map from settings names to a list of observers. Observers get fired in
   // the order they are added.
-  typedef ObserverList<content::NotificationObserver, true>
+  typedef ObserverList<content::NotificationObserver, false>

[pastarmovj, 2012/11/28 09:57:16]

Why did you do that? Is this observer not removed properly?

[bartfab (slow), 2012/11/28 12:30:17]

As discussed offline: I need UserManager to be a CrosSettings observer. Since
UserManager and CrosSettings are both singletons (with undefined shutdown
order), I had to handle both shutdown orders:

* If CrosSettings goes down first, it must accept the fact that UserManager is
still registered as an observer (thus the |false| here).
* If UserManager goes down first, it must unregister itself as an observer
(problem: it does not know whether CrosSettings is still alive) or invalidate
the observer in some other way (I used WeakPtr for this).

These points are now moot as I added a UserManager::Shutdown() method that gets
called during shutdown and allows the UserManager to unregister cleanly.

       NotificationObserverList;
   typedef base::hash_map<std::string, NotificationObserverList*>
       SettingsObserverMap;
   SettingsObserverMap settings_observers_;
 
   DISALLOW_COPY_AND_ASSIGN(CrosSettings);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_SETTINGS_CROS_SETTINGS_H_