Suppress the use of thin archives with android-targeting builds since they break ndk-build.

Suppress the use of thin archives with android-targeting builds since they break ndk-build.

BUG=webrtc:950
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169382

[Ami GONE FROM CHROMIUM, 2012-11-22 17:09:57]

Nico: please see linked webrtc bug for the backstory; basically ndk-build copies
the .a's around the filesystem, and then the build fails because SURPRISE the
relative paths baked into the thin .a's can't be followed.

[Ami GONE FROM CHROMIUM, 2012-11-22 17:16:15]

+peter FYI and in case you can shed light on why the Android port of chromium
doesn't run into this.  Anything downstream doing the same thing, but behind the
curtains?

[Nico, 2012-11-22 18:03:07]

https://codereview.chromium.org/11419139/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/11419139/diff/1/build/common.gypi#newcode2610
build/common.gypi:2610: 'target_conditions': [
Needs a comment.

[Ami GONE FROM CHROMIUM, 2012-11-22 19:47:15]

https://codereview.chromium.org/11419139/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/11419139/diff/1/build/common.gypi#newcode2610
build/common.gypi:2610: 'target_conditions': [
On 2012/11/22 18:03:07, Nico wrote:
> Needs a comment.

Done.

[Peter Beverloo, 2012-11-23 12:04:19]

+bulach

I can't find anything in our repository downstream. As Chrome for Android
doesn't build with WebRTC yet (except the canary on their waterfall), I imagine
that this is a new problem.

[bulach, 2012-11-23 12:10:24]

I don't know if / why the NDK-build copies .a around, adding digit and yfriedman
for more information..

[digit1, 2012-11-23 15:55:57]

lgtm

[digit1, 2012-11-23 15:56:05]

https://codereview.chromium.org/11419139/diff/3/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/11419139/diff/3/build/common.gypi#newcode2613
build/common.gypi:2613: # archives to avoid problems.
I guess you're trying to use the static libraries generated by the Chromium
build in a different ndk-build based project with PREBUILT_STATIC_LIBRARY.

ndk-build copies prebuilt libraries, this is very useful for debugging with
shared libraries, but there is no good reason to do it with static ones. I'll
file a feature request on b.android.com for this, so we can later get rid of
this.

[digit1, 2012-11-23 16:06:43]

Bug filed at http://code.google.com/p/android/issues/detail?id=40302
Feature request at http://code.google.com/p/android/issues/detail?id=40303 :-)

[Ami GONE FROM CHROMIUM, 2012-11-23 17:46:36]

Thanks digit!

(landing on the strength of digit's LGTM since I originally listed Nico only b/c
I was looking at base/OWNERS instead of build/OWNERS)

[commit-bot: I haz the power, 2012-11-23 17:46:48]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[bulach, 2012-11-23 17:47:13]

lgtm, go for it! :)

[Ami GONE FROM CHROMIUM, 2012-11-23 17:47:57]

Well, so much for that...

Nico: please super-star-review!
David: y u no committer??!?!?

[commit-bot: I haz the power, 2012-11-23 17:48:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fischman@chromium.org/11419139/3

[Nico, 2012-11-23 19:17:13]

https://codereview.chromium.org/11419139/diff/3/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/11419139/diff/3/build/common.gypi#newcode2613
build/common.gypi:2613: # archives to avoid problems.
Can you add links to the bugs digit filed? This sounds mostly like and ndk-build
bug workaround.

[Ami GONE FROM CHROMIUM, 2012-11-23 19:40:50]

https://codereview.chromium.org/11419139/diff/3/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/11419139/diff/3/build/common.gypi#newcode2613
build/common.gypi:2613: # archives to avoid problems.
On 2012/11/23 19:17:13, Nico wrote:
> Can you add links to the bugs digit filed? This sounds mostly like and
ndk-build
> bug workaround.

Done.

[Nico, 2012-11-24 00:56:15]

LGTM

Thanks!

On 2012/11/23 19:40:50, Ami Fischman wrote:
> https://codereview.chromium.org/11419139/diff/3/build/common.gypi
> File build/common.gypi (right):
> 
> https://codereview.chromium.org/11419139/diff/3/build/common.gypi#newcode2613
> build/common.gypi:2613: # archives to avoid problems.
> On 2012/11/23 19:17:13, Nico wrote:
> > Can you add links to the bugs digit filed? This sounds mostly like and
> ndk-build
> > bug workaround.
> 
> Done.

[commit-bot: I haz the power, 2012-11-24 00:58:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fischman@chromium.org/11419139/9003

[commit-bot: I haz the power, 2012-11-24 03:35:26]

Change committed as 169382