Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9132)

Unified Diff: build/common.gypi

Issue 11419139: Suppress the use of thin archives with android-targeting builds since they break ndk-build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: incl android bug numbers in comment. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 0a53bfe8a650700e0f62310cb9912e76e662e377..38199a75ed21d9d3b0905b7272db63930cfc2d2f 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2607,6 +2607,16 @@
],
}],
],
+ 'target_conditions': [
+ # ndk-build copies .a's around the filesystem, breaking
+ # relative paths in thin archives. Disable using thin
+ # archives to avoid problems until one of these is fixed:
+ # http://code.google.com/p/android/issues/detail?id=40302
+ # http://code.google.com/p/android/issues/detail?id=40303
+ ['_type=="static_library"', {
+ 'standalone_static_library': 1,
+ }],
+ ],
}],
],
}],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698