Some refactoring in file browser notifications:

Some refactoring in file browser notifications:

- remove GDATA notification types (they're not used anymore).
- when creating notification id for DEVICE_FAIL notification, don't append count
of fail notifications for the failed device (this was used with the old system
notifications api to avoid removing and adding a notification with the same id
in short time span; there were some problems with updating notification message)
- make ShowNotificationWithMessage private
- instead of using switch/case when determining notification parameters for
type, get them from a global (file scoped) array
- make notification id prefixes more descriptive

- make sure there are not multiple DEVICE_HARD_UNPLUG messages for the same
(multipartition) device

TEST=existing
BUG=163252
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170318

[tbarzic, 2012-11-21 22:36:09]

Hey Steven,
can you take a look at this (it's *not* urgent)?

Toni

[stevenjb, 2012-11-27 01:20:08]

lgtm

https://codereview.chromium.org/11418123/diff/1/chrome/browser/chromeos/exten...
File chrome/browser/chromeos/extensions/file_browser_notifications.h (right):

https://codereview.chromium.org/11418123/diff/1/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/file_browser_notifications.h:39: void
RegisterDevice(const std::string& system_path);
nit: blank line

https://codereview.chromium.org/11418123/diff/1/chrome/browser/chromeos/exten...
File
chrome/browser/chromeos/extensions/file_browser_notifications_browsertest.cc
(right):

https://codereview.chromium.org/11418123/diff/1/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/file_browser_notifications_browsertest.cc:154:
// This situation can be encountered while showing nitificaions for
nit: notifications

[commit-bot: I haz the power, 2012-11-29 19:07:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tbarzic@chromium.org/11418123/8001

[commit-bot: I haz the power, 2012-11-29 21:36:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tbarzic@chromium.org/11418123/8001

[commit-bot: I haz the power, 2012-11-30 00:47:55]

Change committed as 170318