Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: chrome/browser/chromeos/extensions/file_browser_event_router.cc

Issue 11418123: Some refactoring in file browser notifications: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix compile Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/file_browser_notifications.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/file_browser_event_router.cc
diff --git a/chrome/browser/chromeos/extensions/file_browser_event_router.cc b/chrome/browser/chromeos/extensions/file_browser_event_router.cc
index 4af966e60842a4206234257507eb216c0ccdb928..77e855d4bee3dbedd4e6786fed8eef73832cd9cd 100644
--- a/chrome/browser/chromeos/extensions/file_browser_event_router.cc
+++ b/chrome/browser/chromeos/extensions/file_browser_event_router.cc
@@ -654,7 +654,8 @@ void FileBrowserEventRouter::OnDiskRemoved(
if (!disk->mount_path().empty()) {
notifications_->ShowNotification(
- FileBrowserNotifications::DEVICE_HARD_UNPLUG, disk->device_path());
+ FileBrowserNotifications::DEVICE_HARD_UNPLUG,
+ disk->system_path_prefix());
DiskMountManager::GetInstance()->UnmountPath(
disk->mount_path(), chromeos::UNMOUNT_OPTIONS_LAZY);
}
@@ -670,10 +671,9 @@ void FileBrowserEventRouter::OnDeviceAdded(
// If the policy is set instead of showing the new device notification we show
// a notification that the operation is not permitted.
if (profile_->GetPrefs()->GetBoolean(prefs::kExternalStorageDisabled)) {
- notifications_->ShowNotificationWithMessage(
- FileBrowserNotifications::DEVICE_FAIL,
- device_path,
- l10n_util::GetStringUTF16(IDS_EXTERNAL_STORAGE_DISABLED_MESSAGE));
+ notifications_->ShowNotification(
+ FileBrowserNotifications::DEVICE_EXTERNAL_STORAGE_DISABLED,
+ device_path);
return;
}
« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/file_browser_notifications.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698