Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11418043: Remove TabContents from OmniboxEditController and friends. (Closed)

Created:
8 years, 1 month ago by Avi (use Gerrit)
Modified:
8 years, 1 month ago
CC:
chromium-reviews, Avi (use Gerrit), groby+watch_chromium.org, creis+watch_chromium.org, tfarina, ajwong+watch_chromium.org, sail+watch_chromium.org, Aaron Boodman, chromium-apps-reviews_chromium.org, gbillock+watch_chromium.org, smckay+watch_chromium.org, rouslan+watch_chromium.org
Visibility:
Public.

Description

Remove TabContents from OmniboxEditController and friends. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168443

Patch Set 1 #

Patch Set 2 : fixins #

Patch Set 3 : cros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -235 lines) Patch
M chrome/browser/chromeos/login/simple_web_view_dialog.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/simple_web_view_dialog.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 9 chunks +15 lines, -22 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/web_intents_button_decoration.h View 3 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/web_intents_button_decoration.mm View 8 chunks +24 lines, -25 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/web_intents_button_decoration_unittest.mm View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.h View 1 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 17 chunks +30 lines, -38 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_controller.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 7 chunks +13 lines, -16 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.cc View 1 2 5 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_decoration_view.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 14 chunks +24 lines, -32 lines 0 comments Download
M chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc View 1 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 1 4 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_info_helper.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/web_intents_button_view.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/web_intents_button_view.cc View 1 2 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_view.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Avi (use Gerrit)
thakis/erg/sky: yer platforms
8 years, 1 month ago (2012-11-16 22:11:16 UTC) #1
tfarina
I guess this overlaps with what I sent to Peter 2 hours ago. http://codereview.chromium.org/11416042/
8 years, 1 month ago (2012-11-16 22:12:15 UTC) #2
tfarina
On Fri, Nov 16, 2012 at 8:12 PM, <tfarina@chromium.org> wrote: > I guess this overlaps ...
8 years, 1 month ago (2012-11-16 22:14:05 UTC) #3
Avi (use Gerrit)
Sorry; didn't catch that you were in this area.
8 years, 1 month ago (2012-11-16 22:16:40 UTC) #4
Elliot Glaysher
gtk parts lgtm
8 years, 1 month ago (2012-11-16 22:16:45 UTC) #5
sky
LGTM
8 years, 1 month ago (2012-11-16 22:41:54 UTC) #6
Nico
lgtm yet a wizard, avi
8 years, 1 month ago (2012-11-16 23:15:36 UTC) #7
Nico
*yer
8 years, 1 month ago (2012-11-16 23:15:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11418043/3002
8 years, 1 month ago (2012-11-17 06:36:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11418043/3002
8 years, 1 month ago (2012-11-17 14:12:31 UTC) #10
commit-bot: I haz the power
8 years, 1 month ago (2012-11-17 15:49:47 UTC) #11 
Change committed as 168443

Powered by Google App Engine
This is Rietveld 408576698