Chromium Code Reviews
Help | Chromium Project | Sign in
(533)

Issue 11416379: Fixes for the upcoming sdk changes (bleeding_edge 16052) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by Siggi Cherem (dart-lang)
Modified:
1 year, 4 months ago
Reviewers:
dgrove, John Messerly
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-ui.git@master
Visibility:
Public.

Description

Fixes for the upcoming sdk changes (bleeding_edge 16052)

Committed: https://github.com/dart-lang/web-ui/commit/13fcc2b

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Lint Patch
M lib/src/emitters.dart View 1 2 3 3 chunks +5 lines, -3 lines 0 comments ? errors Download
M lib/templating.dart View 1 chunk +1 line, -1 line 0 comments ? errors Download
M lib/web_ui.dart View 2 chunks +4 lines, -2 lines 0 comments ? errors Download
M pubspec.yaml View 1 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M test/data/input/mix_iterate_if_test.html View 1 chunk +3 lines, -3 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 4
Siggi Cherem (dart-lang)
1 year, 4 months ago #1
John Messerly
https://codereview.chromium.org/11416379/diff/1/lib/src/emitters.dart File lib/src/emitters.dart (right): https://codereview.chromium.org/11416379/diff/1/lib/src/emitters.dart#newcode519 lib/src/emitters.dart:519: 'autogenerated.insertAllBefore($id.parentNode, $id.nextNode,'); +2 spaces? https://codereview.chromium.org/11416379/diff/1/lib/src/emitters.dart#newcode527 lib/src/emitters.dart:527: printer.add('$id.parentNode.insertBefore($exp, $id.nextNode);'); Can ...
1 year, 4 months ago #2
Siggi Cherem (dart-lang)
also updated the the version number... https://chromiumcodereview.appspot.com/11416379/diff/1/lib/src/emitters.dart File lib/src/emitters.dart (right): https://chromiumcodereview.appspot.com/11416379/diff/1/lib/src/emitters.dart#newcode519 lib/src/emitters.dart:519: 'autogenerated.insertAllBefore($id.parentNode, $id.nextNode,'); On ...
1 year, 4 months ago #3
John Messerly
1 year, 4 months ago #4
lgtm!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6