Fixes for the upcoming sdk changes (bleeding_edge 16052)

lib/src/emitters.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /** Collects several code emitters for the template tool. */
 // TODO(sigmund): add visitor that applies all emitters on a component
 // TODO(sigmund): add support for conditionals, so context is changed at that
 // point.
 library emitters;
 
@@ skipping 497 matching lines @@
     _removeChildNodes(printer);
 
     printer.add('} else if (!_isVisible$id && showNow) {')
         .add('_isVisible$id = true;')
         .add(_childrenCreated);
 
     if (info.isTemplateElement) {
       if (info.children.length > 0) {
         var nodes = info.children.map(_createChildExpression);
         nodes[nodes.length - 1] = '_endPosition$id = ${nodes.last}';
-        printer.add('autogenerated.insertAllBefore($id.parent, $id.nextNode,');
+        printer.add(
+          'autogenerated.insertAllBefore($id.parentNode, $id.nextNode,');

[Jennifer Messerly, 2012/12/12 19:47:18]

+2 spaces?

[Siggi Cherem (dart-lang), 2012/12/12 19:57:42]

Done.

         printer.add('[${Strings.join(nodes, ", ")}]);');
       }
     } else {
       // conditional as attributes mean that the whole conditional is a single
       // node.
       assert(info.children.length == 1);
       var exp = _createChildExpression(info.children[0]);
-      printer.add('$id.parent.insertBefore($exp, $id.nextNode);');
+      printer.add('$id.parentNode.insertBefore($exp, $id.nextNode);');

[Jennifer Messerly, 2012/12/12 19:47:18]

Can we keep using using:

http://api.dartlang.org/docs/bleeding_edge/dart_html/Node.html#parent

?

(I don't think parent would ever be DocumentFragment or CharacterData ... )

[Siggi Cherem (dart-lang), 2012/12/12 19:57:42]

I tried, but I was hitting bugs with ShadowRoot being a document fragment.

     }
 
     printer.add(_childrenInserted).add('''\n}\n}));\n''');
   }
 
   void emitRemoved(Context context) {
     super.emitRemoved(context);
     var id = info.identifier;
     var printer = context.removedMethod;
     printer.add('if (_isVisible$id) {');
@@ skipping 70 matching lines @@
     }
 
     printer.add('for (var $iterExpr) {')
         .add(_childrenDeclarations)
         .add(_childrenCreated);
 
     if (info.children.length > 0) {
       var nodes = info.children.map(_createChildExpression);
       if (info.isTemplateElement) {
         nodes[nodes.length - 1] = '_endPosition$id = ${nodes.last}';
-        printer.add('autogenerated.insertAllBefore($id.parent, __insert_$id,');
+        printer.add(
+          'autogenerated.insertAllBefore($id.parentNode, __insert_$id,');
         printer.add('[${Strings.join(nodes, ", ")}]);');
       } else {
         printer.add('$id.nodes.addAll([${Strings.join(nodes, ", ")}]);');
       }
     }
 
     printer.add(_childrenInserted)
         .add('_removeChild$id.add(() {')
         .add(_childrenRemoved)
         .add('});\n}\n}));');
@@ skipping 311 matching lines @@
     }
     typeName = htmlElementExtends[typeName];
   }
   // If we didn't find a DOM setter, and this is a component, set a property on
   // the component.
   if (info.component != null && !name.startsWith('data-')) {
     return 'xtag.${toCamelCase(name)}';
   }
   return "attributes['$name']";
 }