Chromium Code Reviews Chromium Code Reviews
Issue
11416177:
[content shell] change how the main render view is picked for layout tests (Closed)
Description[content shell] change how the main render view is picked for layout tests
The old code would sometimes crash. The reason is that we need to know which is
the main render view when the first render view is created. The old code,
however, would only pick the main view after it was created.
Individual changes:
- move sending the fake cwd from RenderViewReady to RenderViewCreated so that we can guarantee it's available on time
- Don't guess which WebKitTestRunner belongs to a RenderView, but explictely pass the RenderView with the WebTestProxy creation callback
- instead of having the browser set the main render view, the renderer picks the first RenderView and declares it the main view
BUG=111316
TEST=Running editing/pasteboard/data-transfer-items-drag-drop-string.html doesn't crash
TBR=tsepez@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169455
Patch Set 1 #
Total comments: 2
Patch Set 2 : patch for landing #
Messages
Total messages: 8 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
