Issue 11414240: Only consume a user gesture if we actually create a view

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11414240: Only consume a user gesture if we actually create a view (Closed)

Created:
8 years ago by jochen (gone - plz use gerrit)

Modified:
8 years ago

Reviewers:
jam, Cris Neckar

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Only consume a user gesture if we actually create a view BUG=none R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170543

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	content/renderer/render_view_impl.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 8 (0 generated)

jam

I'm not familiar with this area at all. Can you send to someone more familiar ...

8 years ago (2012-11-29 21:56:56 UTC) #2

Cris Neckar

On 2012/11/29 22:17:01, jochen wrote: > Cris, can you review this please? LGTM

8 years ago (2012-11-29 22:22:18 UTC) #4

jochen (gone - plz use gerrit)

On 2012/11/29 22:22:18, Cris Neckar wrote: > On 2012/11/29 22:17:01, jochen wrote: > > Cris, ...

8 years ago (2012-11-29 22:24:25 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/11414240/1

8 years ago (2012-11-30 19:23:21 UTC) #7

Message was sent while issue was closed.

Change committed as 170543