Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3270)

Unified Diff: content/renderer/render_view_impl.cc

Issue 11414240: Only consume a user gesture if we actually create a view (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 5f1411ceaf91025f28c64ab79deb37ce2a4ef7f8..42c2b84c51aa2c214e28ddda96bada91b1ed2274 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1764,7 +1764,6 @@ WebView* RenderViewImpl::createView(
int32 surface_id = 0;
int64 cloned_session_storage_namespace_id;
- creator->consumeUserGesture();
RenderThread::Get()->Send(
new ViewHostMsg_CreateWindow(params,
&routing_id,
@@ -1773,6 +1772,8 @@ WebView* RenderViewImpl::createView(
if (routing_id == MSG_ROUTING_NONE)
return NULL;
+ creator->consumeUserGesture();
+
RenderViewImpl* view = RenderViewImpl::Create(
routing_id_,
renderer_preferences_,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698