Remove PrefObserver usage, batch 9.

Remove PrefObserver usage, batch 9.

TBR=abodenha@chromium.org,erikkay@chromium.org,erikwright@chromium.org,erg@chromium.org,ben@chromium.org,xiyuan@chromium.org
BUG=155525
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169029

[Mattias Nissler (ping if slow), 2012-11-20 16:23:49]

Code LGTM, but you'll have to rebase I guess.

[commit-bot: I haz the power, 2012-11-20 22:17:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/11414083/6001

[commit-bot: I haz the power, 2012-11-20 22:17:15]

Presubmit check for 11414083-6001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/printing
    chrome/browser/safe_browsing
    chrome/browser/printing/cloud_print
    chrome/browser/net
    chrome/browser/profiles
    chrome/browser/ui
    chrome/browser/ui/app_list

Presubmit checks took 3.9s to calculate.

[Jói, 2012-11-20 22:26:10]

TBR=abodenha@chromium.org,erikkay@chromium.org,erikwright@chromium.org,erg@ch...
for OWNERS stamps for the following:
    chrome/browser/printing
    chrome/browser/safe_browsing
    chrome/browser/printing/cloud_print
    chrome/browser/net
    chrome/browser/profiles
    chrome/browser/ui
    chrome/browser/ui/app_list

This is for an API update where the API change and this entire change was
already reviewed by an OWNER for said API (mnissler@ for Prefs).

Cheers,
Jói

[commit-bot: I haz the power, 2012-11-20 22:26:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/11414083/6001

[commit-bot: I haz the power, 2012-11-21 00:16:43]

Failed to apply patch for chrome/browser/ui/browser_instant_controller.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/browser_instant_controller.h
  Hunk #2 FAILED at 25.
  Hunk #3 succeeded at 80 with fuzz 1 (offset 12 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/ui/browser_instant_controller.h.rej

Patch:       chrome/browser/ui/browser_instant_controller.h
Index: chrome/browser/ui/browser_instant_controller.h
diff --git a/chrome/browser/ui/browser_instant_controller.h
b/chrome/browser/ui/browser_instant_controller.h
index
f00d8e319838e7a257f696bfb0d6d79cca20da33..c8531d07ef216f3f028520b946d7e2d6dd16c5ff
100644
--- a/chrome/browser/ui/browser_instant_controller.h
+++ b/chrome/browser/ui/browser_instant_controller.h
@@ -8,7 +8,6 @@
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/prefs/public/pref_change_registrar.h"
-#include "base/prefs/public/pref_observer.h"
 #include "chrome/browser/instant/instant_controller.h"
 #include "chrome/browser/instant/instant_unload_handler.h"
 #include "chrome/browser/ui/search/search_model_observer.h"
@@ -26,8 +25,7 @@ class Rect;
 
 namespace chrome {
 
-class BrowserInstantController : public PrefObserver,
-                                 public search::SearchModelObserver {
+class BrowserInstantController : public search::SearchModelObserver {
  public:
   explicit BrowserInstantController(Browser* browser);
   virtual ~BrowserInstantController();
@@ -69,9 +67,9 @@ class BrowserInstantController : public PrefObserver,
   void ActiveTabChanged();
 
  private:
-  // Overridden from PrefObserver:
-  virtual void OnPreferenceChanged(PrefServiceBase* service,
-                                   const std::string& pref_name) OVERRIDE;
+  // Sets the value of |instant_| based on value from profile. Invoked
+  // on pref change.
+  void ResetInstant();
 
   // Overridden from search::SearchModelObserver:
   virtual void ModeChanged(const search::Mode& old_mode,

[commit-bot: I haz the power, 2012-11-21 09:22:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/11414083/12003

[commit-bot: I haz the power, 2012-11-21 11:07:06]

Retried try job too often for step(s) content_browsertests

[commit-bot: I haz the power, 2012-11-21 11:13:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/11414083/12003

[commit-bot: I haz the power, 2012-11-21 11:21:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/11414083/8029

[commit-bot: I haz the power, 2012-11-21 13:57:48]

Change committed as 169029