Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1507)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_tab_observer.cc

Issue 11414083: Remove PrefObserver usage, batch 9. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to sort-of good revision (r169014). Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_tab_observer.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_tab_observer.cc b/chrome/browser/safe_browsing/safe_browsing_tab_observer.cc
index 06d4ca13518108496cdbecf9deb5040e514b1b7d..113e3b1b1258cd83b630ff1ab71a717865d92b8a 100644
--- a/chrome/browser/safe_browsing/safe_browsing_tab_observer.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_tab_observer.cc
@@ -38,7 +38,10 @@ SafeBrowsingTabObserver::SafeBrowsingTabObserver(
PrefService* prefs = profile->GetPrefs();
if (prefs) {
pref_change_registrar_.Init(prefs);
- pref_change_registrar_.Add(prefs::kSafeBrowsingEnabled, this);
+ pref_change_registrar_.Add(
+ prefs::kSafeBrowsingEnabled,
+ base::Bind(&SafeBrowsingTabObserver::UpdateSafebrowsingDetectionHost,
+ base::Unretained(this)));
if (prefs->GetBoolean(prefs::kSafeBrowsingEnabled) &&
g_browser_process->safe_browsing_detection_service()) {
@@ -53,22 +56,6 @@ SafeBrowsingTabObserver::~SafeBrowsingTabObserver() {
}
////////////////////////////////////////////////////////////////////////////////
-// content::NotificationObserver overrides
-
-void SafeBrowsingTabObserver::OnPreferenceChanged(
- PrefServiceBase* service,
- const std::string& pref_name) {
- Profile* profile =
- Profile::FromBrowserContext(web_contents_->GetBrowserContext());
- DCHECK(service == profile->GetPrefs());
- if (pref_name == prefs::kSafeBrowsingEnabled) {
- UpdateSafebrowsingDetectionHost();
- } else {
- NOTREACHED() << "unexpected pref change notification" << pref_name;
- }
-}
-
-////////////////////////////////////////////////////////////////////////////////
// Internal helpers
void SafeBrowsingTabObserver::UpdateSafebrowsingDetectionHost() {
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_tab_observer.h ('k') | chrome/browser/ui/app_list/apps_model_builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698