Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: chrome/browser/browsing_data/browsing_data_remover_unittest.cc

Issue 11413050: chrome/browser: Update calls from RunAllPending() to RunUntilIdle(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_remover_unittest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_remover_unittest.cc b/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
index a452429fd28c96c88611907ddaec91498640f0c9..5288f03854416c2412fdb1d5f24982c2befb92a4 100644
--- a/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
+++ b/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
@@ -237,7 +237,7 @@ class RemoveSafeBrowsingCookieTester : public RemoveCookieTester {
SafeBrowsingService::CreateSafeBrowsingService();
browser_process_->SetSafeBrowsingService(sb_service);
sb_service->Initialize();
- MessageLoop::current()->RunAllPending();
+ MessageLoop::current()->RunUntilIdle();
// Create a cookiemonster that does not have persistant storage, and replace
// the SafeBrowsingService created one with it.
@@ -249,7 +249,7 @@ class RemoveSafeBrowsingCookieTester : public RemoveCookieTester {
virtual ~RemoveSafeBrowsingCookieTester() {
browser_process_->safe_browsing_service()->ShutDown();
- MessageLoop::current()->RunAllPending();
+ MessageLoop::current()->RunUntilIdle();
browser_process_->SetSafeBrowsingService(NULL);
}
@@ -498,7 +498,7 @@ class BrowsingDataRemoverTest : public testing::Test,
// the message loop is cleared out, before destroying the threads and loop.
// Otherwise we leak memory.
profile_.reset();
- message_loop_.RunAllPending();
+ message_loop_.RunUntilIdle();
}
void BlockUntilBrowsingDataRemoved(BrowsingDataRemover::TimePeriod period,

Powered by Google App Engine
This is Rietveld 408576698