chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc - Issue 11413050: chrome/browser: Update calls from RunAllPending() to RunUntilIdle().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc

Issue 11413050: chrome/browser: Update calls from RunAllPending() to RunUntilIdle(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc ('k') | chrome/browser/browsing_data/browsing_data_remover_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc

diff --git a/chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc b/chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc

index e28787453e76acdabafa1e6e9e6f95505b9504a9..b905a56925a2df38bfb1171e37262f7100ee4862 100644

--- a/chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc

+++ b/chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc

@@ -49,7 +49,7 @@ class BrowsingDataQuotaHelperTest : public testing::Test {

helper_ = NULL;

quota_manager_ = NULL;

quota_info_.clear();

- MessageLoop::current()->RunAllPending();

+ MessageLoop::current()->RunUntilIdle();

}

protected:

@@ -132,7 +132,7 @@ class BrowsingDataQuotaHelperTest : public testing::Test {

TEST_F(BrowsingDataQuotaHelperTest, Empty) {

StartFetching();

- MessageLoop::current()->RunAllPending();

+ MessageLoop::current()->RunUntilIdle();

EXPECT_TRUE(fetching_completed());

EXPECT_TRUE(quota_info().empty());

}

@@ -147,7 +147,7 @@ TEST_F(BrowsingDataQuotaHelperTest, FetchData) {

RegisterClient(kOrigins, arraysize(kOrigins));

StartFetching();

- MessageLoop::current()->RunAllPending();

+ MessageLoop::current()->RunUntilIdle();

EXPECT_TRUE(fetching_completed());

std::set<QuotaInfo> expected, actual;

@@ -175,7 +175,7 @@ TEST_F(BrowsingDataQuotaHelperTest, IgnoreExtensionsAndDevTools) {

RegisterClient(kOrigins, arraysize(kOrigins));

StartFetching();

- MessageLoop::current()->RunAllPending();

+ MessageLoop::current()->RunUntilIdle();

EXPECT_TRUE(fetching_completed());

std::set<QuotaInfo> expected, actual;

@@ -191,16 +191,16 @@ TEST_F(BrowsingDataQuotaHelperTest, RevokeHostQuota) {

SetPersistentHostQuota(kHost1, 1);

SetPersistentHostQuota(kHost2, 10);

- MessageLoop::current()->RunAllPending();

+ MessageLoop::current()->RunUntilIdle();

RevokeHostQuota(kHost1);

- MessageLoop::current()->RunAllPending();

+ MessageLoop::current()->RunUntilIdle();

GetPersistentHostQuota(kHost1);

- MessageLoop::current()->RunAllPending();

+ MessageLoop::current()->RunUntilIdle();

EXPECT_EQ(0, quota());

GetPersistentHostQuota(kHost2);

- MessageLoop::current()->RunAllPending();

+ MessageLoop::current()->RunUntilIdle();

EXPECT_EQ(10, quota());

}