chrome/browser/safe_browsing/client_side_detection_service_unittest.cc - Issue 11413050: chrome/browser: Update calls from RunAllPending() to RunUntilIdle().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

Issue 11413050: chrome/browser: Update calls from RunAllPending() to RunUntilIdle(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_host_unittest.cc ('k') | chrome/browser/safe_browsing/download_protection_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

index e7e1dbdb2461291e89202fca0ea9eca035254684..45b2591c159970b1cde8c912fc980084acff3e39 100644

--- a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

@@ -72,7 +72,7 @@ class ClientSideDetectionServiceTest : public testing::Test {

}

virtual void TearDown() {

- msg_loop_.RunAllPending();

+ msg_loop_.RunUntilIdle();

csd_service_.reset();

file_thread_.reset();

browser_thread_.reset();

@@ -330,7 +330,7 @@ TEST_F(ClientSideDetectionServiceTest, ServiceObjectDeletedBeforeCallbackDone) {

csd_service_.reset();

// Waiting for the callbacks to run should not crash even if the service

// object is gone.

- msg_loop_.RunAllPending();

+ msg_loop_.RunUntilIdle();

}

TEST_F(ClientSideDetectionServiceTest, SendClientReportPhishingRequest) {

@@ -640,7 +640,7 @@ TEST_F(ClientSideDetectionServiceTest, SetEnabledAndRefreshState) {

EXPECT_TRUE(csd_service_->model_fetcher_.get() != NULL);

csd_service_->SetEnabledAndRefreshState(false);

EXPECT_TRUE(csd_service_->model_fetcher_.get() == NULL);

- msg_loop_.RunAllPending();

+ msg_loop_.RunUntilIdle();

// No calls expected.

Mock::VerifyAndClearExpectations(service);