chrome/browser/safe_browsing/download_protection_service_unittest.cc - Issue 11413050: chrome/browser: Update calls from RunAllPending() to RunUntilIdle().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_protection_service_unittest.cc

Issue 11413050: chrome/browser: Update calls from RunAllPending() to RunUntilIdle(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_service_unittest.cc ('k') | chrome/browser/safe_browsing/malware_details_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_protection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/download_protection_service_unittest.cc b/chrome/browser/safe_browsing/download_protection_service_unittest.cc

index fde46f19ad3372ff03e8418232c3a913eedc1ef4..7a2b01f6e1f38eaebc40831cdeac2d3cf5de2a59 100644

--- a/chrome/browser/safe_browsing/download_protection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/download_protection_service_unittest.cc

@@ -127,7 +127,7 @@ class DownloadProtectionServiceTest : public testing::Test {

download_service_ = sb_service_->download_protection_service();

download_service_->signature_util_ = signature_util_;

download_service_->SetEnabled(true);

- msg_loop_.RunAllPending();

+ msg_loop_.RunUntilIdle();

FilePath source_path;

ASSERT_TRUE(PathService::Get(base::DIR_SOURCE_ROOT, &source_path));

@@ -182,7 +182,7 @@ class DownloadProtectionServiceTest : public testing::Test {

void FlushThreadMessageLoops() {

BrowserThread::GetBlockingPool()->FlushForTesting();

FlushMessageLoop(BrowserThread::IO);

- msg_loop_.RunAllPending();

+ msg_loop_.RunUntilIdle();

}

// Proxy for private method.

@@ -214,7 +214,7 @@ class DownloadProtectionServiceTest : public testing::Test {

private:

// Helper functions for FlushThreadMessageLoops.

void RunAllPendingAndQuitUI() {

- MessageLoop::current()->RunAllPending();

+ MessageLoop::current()->RunUntilIdle();

BrowserThread::PostTask(

BrowserThread::UI,

FROM_HERE,