Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 11412279: Browser Plugin: Only update src attribute on top-level navigations (Closed)

Created:
8 years ago by Fady Samuel
Modified:
8 years ago
Reviewers:
sadrul
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, lazyboy
Visibility:
Public.

Description

Browser Plugin: Only update src attribute on top-level navigations BUG=163665 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170611

Patch Set 1 #

Patch Set 2 : Updated BrowserPluginTest.CustomEvents to cover this change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M content/renderer/browser_plugin/browser_plugin.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_browsertest.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Fady Samuel
8 years ago (2012-11-30 20:14:37 UTC) #1
sadrul
LGTM. You should add a test for this at some point!
8 years ago (2012-11-30 21:52:09 UTC) #2
Fady Samuel
On 2012/11/30 21:52:09, sadrul wrote: > LGTM. > > You should add a test for ...
8 years ago (2012-11-30 22:06:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/11412279/4001
8 years ago (2012-11-30 22:07:07 UTC) #4
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests, compile, crypto_unittests, googleurl_unittests, sql_unittests
8 years ago (2012-11-30 22:13:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/11412279/4001
8 years ago (2012-11-30 22:19:25 UTC) #6
commit-bot: I haz the power
8 years ago (2012-12-01 00:17:06 UTC) #7
Message was sent while issue was closed.
Change committed as 170611

Powered by Google App Engine
This is Rietveld 408576698