Browser Plugin: Only update src attribute on top-level navigations

content/renderer/browser_plugin/browser_plugin_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/browser_plugin/browser_plugin_browsertest.h"
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/memory/singleton.h"
 #include "base/path_service.h"
@@ skipping 373 matching lines @@
     "function nav(e) {"
     "  url = JSON.parse(e.detail).url;"
     "}"
     "document.getElementById('browserplugin')."
     "    addEventListener('-internal-loadcommit', nav);";
   const char* kRemoveEventListener =
     "document.getElementById('browserplugin')."
     "    removeEventListener('-internal-loadcommit', nav);";
   const char* kGetProcessID =
       "document.getElementById('browserplugin').getProcessId()";
+  const char* kGetSrc =
+      "document.getElementById('browserplugin').src";
   const char* kGoogleURL = "http://www.google.com/";
   const char* kGoogleNewsURL = "http://news.google.com/";
 
   LoadHTML(GetHTMLForBrowserPluginObject().c_str());
   ExecuteJavaScript(kAddEventListener);
   // Grab the BrowserPlugin's instance ID from its resize message.
   const IPC::Message* msg =
       browser_plugin_manager()->sink().GetFirstMessageMatching(
           BrowserPluginHostMsg_ResizeGuest::ID);
   ASSERT_TRUE(msg);
   int instance_id = -1;
   BrowserPluginHostMsg_ResizeGuest_Params params;
   BrowserPluginHostMsg_ResizeGuest::Read(msg, &instance_id, &params);
 
   MockBrowserPlugin* browser_plugin =
       static_cast<MockBrowserPlugin*>(
           browser_plugin_manager()->GetBrowserPlugin(instance_id));
   ASSERT_TRUE(browser_plugin);
 
   {
     BrowserPluginMsg_LoadCommit_Params navigate_params;
+    navigate_params.is_top_level = true;
     navigate_params.url = GURL(kGoogleURL);
     navigate_params.process_id = 1337;
     browser_plugin->LoadCommit(navigate_params);
     EXPECT_EQ(kGoogleURL, ExecuteScriptAndReturnString("url"));
+    EXPECT_EQ(kGoogleURL, ExecuteScriptAndReturnString(kGetSrc));
     EXPECT_EQ(1337, ExecuteScriptAndReturnInt(kGetProcessID));
   }
   ExecuteJavaScript(kRemoveEventListener);
   {
     BrowserPluginMsg_LoadCommit_Params navigate_params;
+    navigate_params.is_top_level = false;
     navigate_params.url = GURL(kGoogleNewsURL);
     navigate_params.process_id = 42;
     browser_plugin->LoadCommit(navigate_params);
     // The URL variable should not change because we've removed the event
     // listener.
     EXPECT_EQ(kGoogleURL, ExecuteScriptAndReturnString("url"));
+    // The src attribute should not change if this is a top-level navigation.
+    EXPECT_EQ(kGoogleURL, ExecuteScriptAndReturnString(kGetSrc));
     EXPECT_EQ(42, ExecuteScriptAndReturnInt(kGetProcessID));
   }
 }
 
 TEST_F(BrowserPluginTest, StopMethod) {
   const char* kCallStop =
     "document.getElementById('browserplugin').stop();";
   LoadHTML(GetHTMLForBrowserPluginObject().c_str());
   ExecuteJavaScript(kCallStop);
   EXPECT_TRUE(browser_plugin_manager()->sink().GetUniqueMessageMatching(
@@ skipping 383 matching lines @@
                                               &resize_params);
     EXPECT_FALSE(auto_size_params.enable);
     EXPECT_EQ(42, auto_size_params.min_size.width());
     EXPECT_EQ(43, auto_size_params.min_size.height());
     EXPECT_EQ(1337, auto_size_params.max_size.width());
     EXPECT_EQ(1338, auto_size_params.max_size.height());
   }
 }
 
 }  // namespace content