content/components/web_contents_delegate_android/web_contents_delegate_android.h - Issue 11412274: [Android] Remove onUrlStarChanged method from WebContentsDelegateAndroid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/components/web_contents_delegate_android/web_contents_delegate_android.h

Issue 11412274: [Android] Remove onUrlStarChanged method from WebContentsDelegateAndroid. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/components/web_contents_delegate_android/java/src/org/chromium/content/components/web_contents_delegate_android/WebContentsDelegateAndroid.java ('K') | « content/components/web_contents_delegate_android/java/src/org/chromium/content/components/web_contents_delegate_android/WebContentsDelegateAndroid.java ('k') | content/components/web_contents_delegate_android/web_contents_delegate_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/components/web_contents_delegate_android/web_contents_delegate_android.h

diff --git a/content/components/web_contents_delegate_android/web_contents_delegate_android.h b/content/components/web_contents_delegate_android/web_contents_delegate_android.h

index 967177cc94e71db1d8fecbac6c79810753d2a9fc..f9ba5bf32bf0c7638fbacf4dbef32c36b13e82f5 100644

--- a/content/components/web_contents_delegate_android/web_contents_delegate_android.h

+++ b/content/components/web_contents_delegate_android/web_contents_delegate_android.h

@@ -76,9 +76,6 @@ class WebContentsDelegateAndroid : public WebContentsDelegate {

const string16& message,

int32 line_no,

const string16& source_id) OVERRIDE;

- // TODO(merge): WARNING! method no longer available on the base class.

- // See http://crbug.com/149477

- virtual void URLStarredChanged(WebContents* source, bool starred);

virtual void UpdateTargetURL(WebContents* source,

int32 page_id,

const GURL& url) OVERRIDE;