Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1199)

Unified Diff: content/components/web_contents_delegate_android/web_contents_delegate_android.cc

Issue 11412274: [Android] Remove onUrlStarChanged method from WebContentsDelegateAndroid. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/components/web_contents_delegate_android/web_contents_delegate_android.cc
diff --git a/content/components/web_contents_delegate_android/web_contents_delegate_android.cc b/content/components/web_contents_delegate_android/web_contents_delegate_android.cc
index e212b2c7bbcabc9e091d589a64b903ffe192593e..fcb4951c09f992a75c065778a53116badc1c0773 100644
--- a/content/components/web_contents_delegate_android/web_contents_delegate_android.cc
+++ b/content/components/web_contents_delegate_android/web_contents_delegate_android.cc
@@ -210,17 +210,6 @@ bool WebContentsDelegateAndroid::AddMessageToConsole(
jsource_id.obj());
}
-// TODO(merge): WARNING! method no longer available on the base class.
-// See http://crbug.com/149477
-void WebContentsDelegateAndroid::URLStarredChanged(WebContents* source,
- bool starred) {
- JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env);
- if (obj.is_null())
- return;
- Java_WebContentsDelegateAndroid_onUrlStarredChanged(env, obj.obj(), starred);
-}
-
// This is either called from TabContents::DidNavigateMainFramePostCommit() with
// an empty GURL or responding to RenderViewHost::OnMsgUpateTargetURL(). In
// Chrome, the latter is not always called, especially not during history

Powered by Google App Engine
This is Rietveld 408576698