Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 11412274: [Android] Remove onUrlStarChanged method from WebContentsDelegateAndroid. (Closed)

Created:
8 years ago by John Knottenbelt
Modified:
8 years ago
Reviewers:
joth
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org
Visibility:
Public.

Description

[Android] Remove onUrlStarChanged method from WebContentsDelegateAndroid. This method is unused in Chromium and downstream, so remove it. BUG=149477 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170578

Patch Set 1 #

Total comments: 1

Messages

Total messages: 4 (0 generated)
John Knottenbelt
Here's the follow up, as requested :)
8 years ago (2012-11-30 18:21:25 UTC) #1
joth
lgtm https://codereview.chromium.org/11412274/diff/1/content/components/web_contents_delegate_android/java/src/org/chromium/content/components/web_contents_delegate_android/WebContentsDelegateAndroid.java File content/components/web_contents_delegate_android/java/src/org/chromium/content/components/web_contents_delegate_android/WebContentsDelegateAndroid.java (right): https://codereview.chromium.org/11412274/diff/1/content/components/web_contents_delegate_android/java/src/org/chromium/content/components/web_contents_delegate_android/WebContentsDelegateAndroid.java#newcode51 content/components/web_contents_delegate_android/java/src/org/chromium/content/components/web_contents_delegate_android/WebContentsDelegateAndroid.java:51: public void onLoadStarted() { poor old Rietveld. I'm ...
8 years ago (2012-11-30 20:42:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jknotten@chromium.org/11412274/1
8 years ago (2012-11-30 20:42:57 UTC) #3
commit-bot: I haz the power
8 years ago (2012-11-30 22:32:51 UTC) #4
Message was sent while issue was closed.
Change committed as 170578

Powered by Google App Engine
This is Rietveld 408576698