Issue 11412202: Made MaybeCompleteDownload private.

Issue 11412202: Made MaybeCompleteDownload private. (Closed)

Created:
8 years ago by Randy Smith (Not in Mondays)

Modified:
8 years ago

Reviewers:
asanka

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, rdsmith+dwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make MaybeCompleteDownload private. R=asanka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170533

Patch Set 2 : Fixed indentation. #

Total comments: 2

Patch Set 3 : Removed virtuals from various private methods on DownloadItemImpl." #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -20 lines)			Patch
M	content/browser/download/download_item_impl.h	View	1 2	4 chunks	+8 lines, -8 lines	0 comments	Download
M	content/browser/download/download_item_impl.cc	View		1 chunk	+4 lines, -5 lines	0 comments	Download
M	content/browser/download/download_item_impl_unittest.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	content/browser/download/download_manager_impl_unittest.cc	View		2 chunks	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

asanka

LGTM https://codereview.chromium.org/11412202/diff/3001/content/browser/download/download_item_impl.h File content/browser/download/download_item_impl.h (right): https://codereview.chromium.org/11412202/diff/3001/content/browser/download/download_item_impl.h#newcode261 content/browser/download/download_item_impl.h:261: virtual void MaybeCompleteDownload(); Does this need to be ...

8 years ago (2012-11-28 16:24:41 UTC) #2

Randy Smith (Not in Mondays)

https://codereview.chromium.org/11412202/diff/3001/content/browser/download/download_item_impl.h File content/browser/download/download_item_impl.h (right): https://codereview.chromium.org/11412202/diff/3001/content/browser/download/download_item_impl.h#newcode261 content/browser/download/download_item_impl.h:261: virtual void MaybeCompleteDownload(); On 2012/11/28 16:24:41, asanka wrote: > ...

8 years ago (2012-11-28 20:28:26 UTC) #3